Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: graduate the kubeadm configuration #970

Open
1 task done
neolit123 opened this issue Apr 17, 2019 · 62 comments
Open
1 task done

kubeadm: graduate the kubeadm configuration #970

neolit123 opened this issue Apr 17, 2019 · 62 comments
Assignees
@neolit123
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@neolit123
Copy link
Member

neolit123 commented Apr 17, 2019 •
edited

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Iterate on the kubeadm configuration (API) until it graduates to GA

1.15

for the 1.15 cycle we want to upgrade the config type from v1beta1 to v1beta2.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1439

1.22

for the 1.22 cycle we want to upgrade the config type from v1beta2 to v1beta3.
Umbrella issue for tracking this work:
kubernetes/kubeadm#1796

KEP updates:
@k8s-ci-robot
Copy link
Contributor

@neolit123: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <group-name>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 17, 2019
@neolit123 neolit123 added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 17, 2019
@neolit123 neolit123 added this to the v1.15 milestone Apr 17, 2019
@rosti rosti mentioned this issue Apr 17, 2019
Closed
4 tasks
@neolit123 neolit123 added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Apr 17, 2019
@rosti
Copy link
Contributor

rosti commented Apr 17, 2019

/assign

@rosti
Copy link
Contributor

rosti commented Apr 17, 2019

Thanks for creating the issue @neolit123 !

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 17, 2019
@rosti rosti mentioned this issue Apr 17, 2019
Merged
@neolit123 neolit123 changed the title kubeadm: upgrade the configuration to v1beta2 kubeadm: graduate the kubeadm configuration to GA Apr 18, 2019
@neolit123 neolit123 changed the title kubeadm: graduate the kubeadm configuration to GA kubeadm: graduate the kubeadm configuration Apr 18, 2019
@neolit123
Copy link
Member Author

@rosti
updated the description and title.

@rosti rosti mentioned this issue Apr 24, 2019
Merged
@craiglpeters
Copy link
Contributor

@fabriziopandini and @luxas, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@neolit123 neolit123 mentioned this issue Apr 29, 2019
Merged
@neolit123
Copy link
Member Author

@craiglpeters thanks for the heads up. done:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md

@rosti rosti mentioned this issue May 2, 2019
Merged
@rosti rosti mentioned this issue May 10, 2019
Merged
@christianh814
Copy link

Hey @neolit123 and @rosti I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@neolit123
Copy link
Member Author

hi @christianh814
this work will require minor updates on already existing links to the godocs documentation of the kubeadm API. we are going to have the PRs up before the 31st.

thanks for the heads up.

@rosti rosti mentioned this issue May 27, 2019
Merged
@craiglpeters
Copy link
Contributor

Hi @rosti. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@makoscafee
Copy link

Hi, @neolit123 I am docs Lead.
Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must have placeholder docs PRs open.
Just friendly following up on this. Thanks

@rosti
Copy link
Contributor

rosti commented May 29, 2019 •
edited

Thanks for the reminder @makoscafee and @craiglpeters !

@rosti rosti mentioned this issue May 29, 2019
Merged
@rosti
Copy link
Contributor

rosti commented May 29, 2019

@craiglpeters
kubernetes/kubernetes#77739
kubernetes/kubernetes#78403

@makoscafee
kubernetes/website#14607

Those are the PRs.

@jrsapi
Copy link

jrsapi commented May 9, 2021 •
edited

Greetings @neolit123!
1.22 Enhancement shadow checking in. The Enhancement freeze is this Thursday, 5/13. In reviewing your KEP, one item needing attention before the freeze:

  • (PRR) Production readiness review needs to be approved. #prod-readiness channel on K8s slack can assist.

Thanks!

@neolit123
Copy link
Member Author

@jrsapi hello,
the kubeadm API predates the PRR process. it was never done for it and is arguably not needed.
based on recent discussions, PRR was partially a no-op for another kubeadm KEP:
#2620 (comment)

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

@jrsapi
Copy link

jrsapi commented May 10, 2021 •
edited

Thanks for the link to the comment. I'll move the to "Tracked" in the Enhancement spreadsheet.

@ehashman
Copy link
Member

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

This is already true; PRR is optional for out-of-tree components. We discussed this at the last PRR meeting.

@PI-Victor
Copy link
Member

Hello @neolit123 👋, 1.22 Docs release lead here.

This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Can you confirm that kubernetes/website#28010 is related to this KEP?
If there are any other changes that need docs updates, please open a PR against k/website dev-1.22 branch before Fri July 9, 11:59 PM PDT (docs placeholder PR deadline).
thank you

@neolit123
Copy link
Member Author

neolit123 commented May 18, 2021 via email

@jrsapi
Copy link

jrsapi commented Jun 24, 2021

Greetings @neolit123,
Enhancement team shadow checking in with a few updates. Currently, we are tracking this PR for the 1.22 milestone. Are there any other PR's that are not linked that should be tracked?

A reminder about code freeze which is July 8th, 2021 11:59 PST. All implementation PR's must be code complete and merged before the deadline. Thanks for your partnership.

@neolit123
Copy link
Member Author

neolit123 commented Jun 24, 2021 via email •
edited

@neolit123
Copy link
Member Author

@jrsapi
we consider the work for this "feature" in 1.22 completed (minus docs).
the "feature" remains in "beta".

the full list of merged PRs is here:
kubernetes/kubeadm#1796

e2e tests are updated:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm

docs PR is pending /lgtm:
kubernetes/website#28360

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@neolit123 neolit123 mentioned this issue Sep 9, 2021
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021
@neolit123
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 18, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2022
@neolit123 neolit123 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2022
@neolit123 neolit123 mentioned this issue Sep 29, 2022
Closed
4 tasks
@rhockenbury
Copy link

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone Oct 1, 2022
@pacoxu
Copy link
Member

pacoxu commented Mar 14, 2023 •
edited

v1beta4 candidate

@pacoxu pacoxu mentioned this issue Mar 22, 2023
Closed
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@chendave chendave mentioned this issue Jun 9, 2023
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neolit123 neolit123

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests