Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3rd party device monitoring plugins #606

Closed
4 tasks
dashpole opened this issue Jul 31, 2018 · 114 comments · Fixed by kubernetes/kubernetes#92165
Closed
4 tasks

Support 3rd party device monitoring plugins #606

dashpole opened this issue Jul 31, 2018 · 114 comments · Fixed by kubernetes/kubernetes#92165
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@dashpole
Copy link
Contributor

dashpole commented Jul 31, 2018

Feature Description

  1. As a cluster admin, I want container-level metrics for devices provided by device plugins.
  2. As a device vendor, I want to be able to provide device-specific metrics without contributing to core kubernetes.

/kind feature
/sig node

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 31, 2018
@kacole2
Copy link
Contributor

kacole2 commented Jul 31, 2018

@dashpole this has been added to the 1.12 tracking sheet. Thank you

@justaugustus please add relevant tags to this issue

@justaugustus justaugustus added this to the v1.12 milestone Jul 31, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 31, 2018
@justaugustus
Copy link
Member

@kacole2 all set!

@vikaschoudhary16
Copy link

@dashpole looks like design proposal link should be this one: https://docs.google.com/document/d/1NYnqw-HDQ6Y3L_mk85Q3wkxDtGNWTxpsedsgw4NgWpg/edit

@dashpole
Copy link
Contributor Author

dashpole commented Aug 1, 2018

Agreed, that makes more sense

@justaugustus
Copy link
Member

/assign @dashpole

@zparnold
Copy link
Member

Hey there! @dashpole I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@dashpole
Copy link
Contributor Author

@zparnold here is the docs pr placeholder: kubernetes/website#9945

@zparnold
Copy link
Member

Thank you @dashpole!

@justaugustus
Copy link
Member

@dashpole --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@dashpole
Copy link
Contributor Author

dashpole commented Sep 5, 2018

It can be removed from the milestone

@justaugustus
Copy link
Member

Got it. Thanks for the update!

@justaugustus justaugustus added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 5, 2018
@justaugustus justaugustus removed this from the v1.12 milestone Sep 5, 2018
@kacole2
Copy link
Contributor

kacole2 commented Oct 8, 2018

Hi @dashpole
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. I can see that your original post says Alpha for 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to ping @kacole2 so it can be included in the 1.13 Enhancements Tracking Sheet if it's going to make it.

Thanks!

@kacole2
Copy link
Contributor

kacole2 commented Oct 8, 2018

/milestone v1.13
/tracked yes

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 8, 2018
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 8, 2018
@AishSundar
Copy link

@dashpole could you please let us know whats pending for this feature to go to Alpha in 1.13. Do you have a list of pending PRs or issues you can point us to. Thanks

@claurence
Copy link

@dashpole there has been no communication on the status. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks!

@dashpole
Copy link
Contributor Author

KEP: kubernetes/community#2454 should be merged soon, as it is approved by the required people. Once that happens, Ill open the implementation PR, and get working on docs. I still expect this to land in 1.13.

@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 31, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 5, 2023

Hello @ffromani @dashpole 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting staying for stage stable for v1.28

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to update the following:

  • Get approval from the PRR authors.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@ffromani
Copy link
Contributor

ffromani commented Jun 5, 2023

Hello @ffromani @dashpole wave, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting staying for stage stable for v1.28

Here's where this enhancement currently stands:

* [x]  KEP readme using the [latest template](https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) has been merged into the k/enhancements repo.

* [x]  KEP status is marked as `implementable` for `latest-milestone:v1.28`

* [x]  KEP readme has a [updated detailed test plan section](https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md?plain=1#L257-L328) filled out

* [x]  KEP readme has up to date graduation criteria

* [ ]  KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to update the following:

* Get approval from the PRR authors.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

@Atharva-Shinde
Copy link
Contributor

@ffromani Thanks for confirming! With all the requirements fulfilled, I will mark this enhancement as tracked for the Enhancements freeze.

@Rishit-dagli
Copy link
Member

Hello @dashpole 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@ffromani
Copy link
Contributor

ffromani commented Jul 2, 2023

Hello @dashpole 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi, I'm handling the GA graduation. Please find the relevant PR: kubernetes/website#41804
tracking here: #3743

@Atharva-Shinde
Copy link
Contributor

Hey again @ffromani 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

As per your comment above I believe that there are no active PR/s remaining that needs to be merged in k/k. But still if there are any k/k related PR/s that we should be tracking for this KEP please link them in the issue description above.

Also please keep the issue description up-to-date with all the PR/s that are associated with this KEP.

As always, we are here to help if any questions come up. Thanks!

ffromani added a commit to ffromani/website that referenced this issue Jul 17, 2023
…g post about it.

I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancement:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor

ffromani commented Jul 18, 2023

Hey again @ffromani wave

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

* [x]  **All** the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.

* [x]  All code related PR/s are merged or are in merge-ready state ( i.e they have `approved` and `lgtm` labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

As per your comment above I believe that there are no active PR/s remaining that needs to be merged in k/k. But still if there are any k/k related PR/s that we should be tracking for this KEP please link them in the issue description above.

Also please keep the issue description up-to-date with all the PR/s that are associated with this KEP.

As always, we are here to help if any questions come up. Thanks!

Hi @Atharva-Shinde , I'm writing this so I can confirm that all relevant PRs (KEP, code, docs) are merged and from my POV everything looks good for this enhancement. Because I don't have edit access to this (the original) issue, I'm keeping the state up to date in #3743 - the latter covers the GA graduation of this feature.

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jul 19, 2023

Hey @dashpole @ffromani 👋 Enhancements Lead here,

Hi @Atharva-Shinde , I'm writing this so I can confirm that all relevant PRs (KEP, code, docs) are merged and from my POV everything looks good for this enhancement. Because I don't have edit access to this (the original) issue, I'm keeping the state up to date in #3743 - the latter covers the GA graduation of this feature.

With all implementation PRs merged as per the issue description from this issue and issue number #3743, this enhancement is now tracked for v1.28 Code Freeze!
kubernetes/kubernetes#115133
kubernetes/kubernetes#116459
kubernetes/kubernetes#115926
kubernetes/kubernetes#116525

ffromani added a commit to ffromani/website that referenced this issue Aug 2, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 2, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 3, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 8, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 11, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 11, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@ffromani
Copy link
Contributor

ffromani commented Aug 28, 2023

/close

mirroring the status reported in #3743, all work here is done, so I think we can close this issue.

@k8s-ci-robot
Copy link
Contributor

@ffromani: Closing this issue.

In response to this:

/close

mirroring the status reported in #3743, all work here is done, so I think we can close this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Removed From Milestone
Status: Tracked