-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APICategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.Categorizes an issue or PR as relevant to SIG Scheduling.stage/stableDenotes an issue tracking an enhancement targeted for Stable/GA statusDenotes an issue tracking an enhancement targeted for Stable/GA statustracked/noDenotes an enhancement issue is NOT actively being tracked by the Release TeamDenotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone
Description
Feature Description
- One-line feature description (can be used as a release note): Pod priority and preemption enables Kubernetes scheduler to schedule more important Pods first and when cluster is out of resources, it removes less important pods to create room for more important ones. The importance is specified by priority.
- Primary contact (assignee): @bsalamat
- Responsible SIGs: scheduling
- Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/scheduling/pod-preemption.md
- Link to e2e and/or unit tests: https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/preemption_test.go
- Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @k82cn @davidopp
- Approver (likely from SIG/area to which feature belongs): @k82cn
- Feature target (which target equals to which milestone):
- Alpha release target (x.y) 1.8
- Beta release target (x.y) 1.11
- Stable release target (x.y) 1.14
/stage beta
/sig scheduling
/kind feature
prestonvanloon
Metadata
Metadata
Labels
kind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APICategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.Categorizes an issue or PR as relevant to SIG Scheduling.stage/stableDenotes an issue tracking an enhancement targeted for Stable/GA statusDenotes an issue tracking an enhancement targeted for Stable/GA statustracked/noDenotes an enhancement issue is NOT actively being tracked by the Release TeamDenotes an enhancement issue is NOT actively being tracked by the Release Team
Type
Projects
Relationships
Development
Select code repository
Activity
justaugustus commentedon Apr 24, 2018
/assign @bsalamat
justaugustus commentedon Jun 4, 2018
@bsalamat --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?
kacole2 commentedon Jul 23, 2018
@bsalamat This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12.
If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.
Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.
In addition, please be aware of the following relevant deadlines:
Please make sure all PRs for features have relevant release notes included as well.
Happy shipping!
bsalamat commentedon Jul 28, 2018
This feature is built and graduated to Beta in 1.11. We don't have a clear milestone for GA at this point as we have not received enough feedback about it yet.
fejta-bot commentedon Oct 29, 2018
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
/remove-lifecycle stale
.Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
/close
.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
20 remaining items
bsalamat commentedon Feb 23, 2019
@claurence Could you please elaborate or refer me to an example of needed testing plans? This feature existed and already has unit, integration, and e2e tests and graduation to stable comes with no functionality change. So, there is no need to specifically add tests for the stable version.
lachie83 commentedon Feb 25, 2019
Hello @bsalamat, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks
bsalamat commentedon Feb 25, 2019
Hi @lachie83, The only remaining PR is kubernetes/kubernetes#74465 which is actually just a comment update to mark older versions of the API deprecated. Other changes are already merged.
claurence commentedon Feb 26, 2019
@bsalamat if the tests exist can you PR a link to them into the KEP so they are easy for CI Signal and others to find?
lachie83 commentedon Mar 6, 2019
@bsalamat can you please provide an update on the @claurence comment regarding tests?
bsalamat commentedon Mar 6, 2019
@claurence @lachie83 I just sent a PR to add testing plan to the KEP.
bsalamat commentedon Mar 13, 2019
Pod priority and preemption is in GA in 1.14. With that, we can close this enhancement request.
RehanSaeed commentedon Mar 26, 2019
The docs still mention
scheduling.k8s.io/v1beta1
as theapiVersion
. Can we now switch tov1
?bsalamat commentedon Mar 26, 2019
@RehanSaeed Yes. I will send a PR to change the example to v1. Thanks for reporting it.