-
Notifications
You must be signed in to change notification settings - Fork 384
tasks to finish 4.2 support #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@kares What do you think for we should do for |
I'm sorry, I can not tell without looking in detail ... I recall it's a "hack" to support conversion to Time and similar on the Java side. got introduced with the compatibility for custom selects such as |
I'd just like to mention that I've added a $100 bounty to this project on BountySouce. |
Any further news on progress toward Rails 4.2 compatability? |
Please note that the uuid native postgres type is not supported in the 4.2 version of the adapter. It works fine with 4.0 though. Many thanks for working on this! |
I've added a bounty of 250USD to the project |
Added another $15 and sent the bounty around on my social medias. |
JRuby-based Rails 4.2 unable to let gem to generate model for us. For example, Remexify gem (and also Devise) were unable of generating model from scratch through its generate command. |
we're working on it ... it still might need a week or two to get pass (hopefully most) supported adapters. |
Oh awesome. Need help testing anything? |
@Ch4s3 you could run against our 1-3-stable branch as it's already (and still expected) to be updated. |
Ok, so 1-3-stable seems to work fine with jRuby 9000, Rails 4.2.3 for may app. I ran rake db:reset and a bunch of Postgres heavy rspec tests. |
@kares Should we close this now? AR 4.2 is now supported on all but the special adapters: oracle, db2, firebird, and mssql. We could track these in separat issues, and only emit the AR 4.2 warning for these adapters. |
do not see a reason why we should split it for a "few left" at least until a review is done. would prefer to keep the warning until the generic jdbc case handles type resolution to at least some degree (like it used to on pre 4.2) - travis-ci fully green ... think we're close but there's no need to rush. the hard work (after some of the special one reviews) will be mostly about supporting bug reports anyways. |
👍 |
after 1.3.17 that included a lot of AR 4.2 compatibility improvements, mostly for MySQL/PostgreSQL as well as the generic JDBC adapter, in 1.3.18 literally all adapters have been reviewed to support AR 4.2 to around the same extent as they handle previous AR versions ... some of course need real-world usage to confirm thus warnings are left on Oracle/DB2/MSSQL despite support being there. also worth mentioning that generic adapter: jdbc and AR-JDBC extension gems should have an easier job of handling changes such as the 'new' |
cast_type
around in Column instancestype_cast
working with Derby: Gettype_cast
working with Derby #662_string_to_time
emulation on our 1.3.x line (for custom selects e.g.SELECT now()
)cast_type
param rails/rails@4bd5dffc85a4f3a660Column
s in a backward-compatible waytype_cast
needs to be reviewed 4 all adapters rails/rails@e781aa31fc52aprimary
method rails/rails@05dd3df (see RubyJdbcConnection.java references primary= method which has been removed in ActiveRecord 4.2.0 #609)column.primary
inprefetch_primary_key?
column.primary
inprefetch_primary_key?
db2 depends oncolumn.primary
(but only in quote - should be fajn)column.primary
indetermine_order_clause
... fix remaining/reported 4.2 bugs (besides getting the test suite green 4 all)
you can support AR 4.2 support at BountySource
--- The **[$1,700 bounty](https://www.bountysource.com/issues/5831191-tasks-to-finish-4-2-support?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github).The text was updated successfully, but these errors were encountered: