introduce new feature flag for auto_sni #38604
Merged
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-policy-bot
added
area/networking
release-notes-none
istio-testing
added
the
size/S
kfaseela
force-pushed
the
feature-flag-for-auto-sni
branch
from
aa85f66 to
33b4692
Compare
A later discussion concluded that it makes better sense to introduce a new feature flag for enabling auto_sni, and auto_san_validation should be clubbed with VERIFY_CERT_AT_CLIENT. RFC has been updated accordingly. Signed-off-by: Faseela K <faseela.k@est.tech>
kfaseela
force-pushed
the
feature-flag-for-auto-sni
branch
from
33b4692 to
274c406
Compare
howardjohn
approved these changes
Apr 26, 2022
|
/retest |
|
/test integ-pilot-istiodremote-mc_istio |
|
In response to a cherrypick label: new pull request created: #38611 |
9 tasks
l8huang
pushed a commit
to l8huang/istio
that referenced
this pull request
Jun 16, 2022
* Add auto-sni support (istio#38238) * [WIP] Add auto-sni support Signed-off-by: Faseela K <faseela.k@est.tech> * Fix unit test failure Signed-off-by: Faseela K <faseela.k@est.tech> * enhance release-notes and small code improvements Signed-off-by: Faseela K <faseela.k@est.tech> * introduce new feature flag for auto_sni (istio#38604) A later discussion concluded that it makes better sense to introduce a new feature flag for enabling auto_sni, and auto_san_validation should be clubbed with VERIFY_CERT_AT_CLIENT. RFC has been updated accordingly. Signed-off-by: Faseela K <faseela.k@est.tech> * fix unit test Co-authored-by: Faseela K <faseela.k@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A later discussion concluded that it makes better sense
to introduce a new feature flag for enabling auto_sni,
and only auto_san_validation should be clubbed with existing VERIFY_CERT_AT_CLIENT feature flag.
RFC has been updated accordingly.
Signed-off-by: Faseela K faseela.k@est.tech
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.