Skip to content

Add auto-sni support #38238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

kfaseela
Copy link
Member

@kfaseela kfaseela commented Apr 4, 2022

Signed-off-by: Faseela K faseela.k@est.tech

Please provide a description of this PR:

RFC auto-sni support

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • [X ] Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

Sorry, something went wrong.

@kfaseela kfaseela requested review from a team as code owners April 4, 2022 20:57
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 4, 2022
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 4, 2022
@kfaseela
Copy link
Member Author

kfaseela commented Apr 4, 2022

/ok-to-test

@istio-testing istio-testing added the ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. label Apr 4, 2022
@kfaseela kfaseela changed the title [WIP] Add auto-sni support Add auto-sni support Apr 5, 2022
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 5, 2022
@kfaseela
Copy link
Member Author

kfaseela commented Apr 5, 2022

/retest

kfaseela added 3 commits April 6, 2022 16:25
Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela force-pushed the auto-sni-and-san-support branch from 5e56e23 to d3462a1 Compare April 6, 2022 14:47
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2022
Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Kmoneal
Copy link
Contributor

Kmoneal commented Apr 6, 2022

LGTM

@istio-testing istio-testing merged commit 7ed6cf2 into istio:master Apr 6, 2022
aryan16 pushed a commit to aryan16/istio that referenced this pull request Apr 8, 2022
* [WIP] Add auto-sni support

Signed-off-by: Faseela K <faseela.k@est.tech>

* Fix unit test failure

Signed-off-by: Faseela K <faseela.k@est.tech>

* enhance release-notes and small code improvements

Signed-off-by: Faseela K <faseela.k@est.tech>
aryan16 pushed a commit to aryan16/istio that referenced this pull request Apr 11, 2022
* [WIP] Add auto-sni support

Signed-off-by: Faseela K <faseela.k@est.tech>

* Fix unit test failure

Signed-off-by: Faseela K <faseela.k@est.tech>

* enhance release-notes and small code improvements

Signed-off-by: Faseela K <faseela.k@est.tech>
l8huang pushed a commit to l8huang/istio that referenced this pull request Jun 16, 2022
* Add auto-sni support (istio#38238)

* [WIP] Add auto-sni support

Signed-off-by: Faseela K <faseela.k@est.tech>

* Fix unit test failure

Signed-off-by: Faseela K <faseela.k@est.tech>

* enhance release-notes and small code improvements

Signed-off-by: Faseela K <faseela.k@est.tech>

* introduce new feature flag for auto_sni (istio#38604)

A later discussion concluded that it makes better sense
to introduce a new feature flag for enabling auto_sni,
and auto_san_validation should be clubbed with VERIFY_CERT_AT_CLIENT.
RFC has been updated accordingly.

Signed-off-by: Faseela K <faseela.k@est.tech>

* fix unit test

Co-authored-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela deleted the auto-sni-and-san-support branch August 5, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants