Skip to content

Support http 1.0 traffic in Istio #11235

Closed
@wattli

Description

@wattli
Contributor
No description provided.

Activity

added this to the 1.1 milestone on Jan 24, 2019
duderino

duderino commented on Jan 30, 2019

@duderino
Contributor

@costinm @rshriram @PiotrSikora, any objection to just turning HTTP/1.0 on by default? Does it have to be exposed to the user or can this just be between Pilot and Envoy?

duderino

duderino commented on Jan 30, 2019

@duderino
Contributor

@philrud will work on this, but I can't assign the bug to him until he becomes a member of the github org

PiotrSikora

PiotrSikora commented on Jan 30, 2019

@PiotrSikora
Contributor

@wattli any context?

@duderino isn't Pilot<>Envoy over gRPC?

duderino

duderino commented on Jan 31, 2019

@duderino
Contributor

@PiotrSikora this would be for dataplane traffic. Stuff like old versions of curl, old client libs, etc still speak HTTP/1.0

duderino

duderino commented on Jan 31, 2019

@duderino
Contributor

More specifically, this is for traffic from the application to the sidecar (aka sidecar capture).

See https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-http1protocoloptions - specifically "accept_http_10"

In the interest of expediency, @costinm will take this on himself.

PiotrSikora

PiotrSikora commented on Jan 31, 2019

@PiotrSikora
Contributor

Yup, sorry, I got confused by "can this just be between Pilot and Envoy", but I see that you only meant that for "hardcoded" config emitted from Pilot (i.e. always set accept_http_10: true) and not for HTTP/1.0 traffic between Pilot and Enovy.

esnible

esnible commented on Feb 1, 2019

@esnible
Contributor

Adding the user-experience tag because this greatly confused me when I started Istio.

Our documentation at https://istio.io/docs/setup/kubernetes/quick-start/ says "... HTTP/1.0 is not supported" If we choose NOT to support 1.0, we should add some documentation that if installing Istio causes "426 Upgrade Required" errors for apps using 1.0. Users who hit this will do a web search on the error code, 426, not the problem.

costinm

costinm commented on Feb 19, 2019

@costinm
Contributor

Fixed in 1.1

hmakkapati

hmakkapati commented on Mar 20, 2019

@hmakkapati

Costin's fix: #11511

Sherler

Sherler commented on Mar 22, 2019

@Sherler

Fixed in 1.1

Is there any instructions or demo to help us enable this feature? @costinm

wu0407

wu0407 commented on Nov 25, 2019

@wu0407

Fixed in 1.1

Is there any instructions or demo to help us enable this feature? @costinm

istioctl manifest apply --set values.pilot.env.PILOT_HTTP10=1

#13085 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @costinm@PiotrSikora@duderino@esnible@hmakkapati

      Issue actions

        Support http 1.0 traffic in Istio · Issue #11235 · istio/istio