You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@costinm@rshriram@PiotrSikora, any objection to just turning HTTP/1.0 on by default? Does it have to be exposed to the user or can this just be between Pilot and Envoy?
Yup, sorry, I got confused by "can this just be between Pilot and Envoy", but I see that you only meant that for "hardcoded" config emitted from Pilot (i.e. always set accept_http_10: true) and not for HTTP/1.0 traffic between Pilot and Enovy.
Adding the user-experience tag because this greatly confused me when I started Istio.
Our documentation at https://istio.io/docs/setup/kubernetes/quick-start/ says "... HTTP/1.0 is not supported" If we choose NOT to support 1.0, we should add some documentation that if installing Istio causes "426 Upgrade Required" errors for apps using 1.0. Users who hit this will do a web search on the error code, 426, not the problem.
Activity
duderino commentedon Jan 30, 2019
@costinm @rshriram @PiotrSikora, any objection to just turning HTTP/1.0 on by default? Does it have to be exposed to the user or can this just be between Pilot and Envoy?
duderino commentedon Jan 30, 2019
@philrud will work on this, but I can't assign the bug to him until he becomes a member of the github org
PiotrSikora commentedon Jan 30, 2019
@wattli any context?
@duderino isn't Pilot<>Envoy over gRPC?
duderino commentedon Jan 31, 2019
@PiotrSikora this would be for dataplane traffic. Stuff like old versions of curl, old client libs, etc still speak HTTP/1.0
duderino commentedon Jan 31, 2019
More specifically, this is for traffic from the application to the sidecar (aka sidecar capture).
See https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-http1protocoloptions - specifically "accept_http_10"
In the interest of expediency, @costinm will take this on himself.
PiotrSikora commentedon Jan 31, 2019
Yup, sorry, I got confused by "can this just be between Pilot and Envoy", but I see that you only meant that for "hardcoded" config emitted from Pilot (i.e. always set
accept_http_10: true
) and not for HTTP/1.0 traffic between Pilot and Enovy.esnible commentedon Feb 1, 2019
Adding the user-experience tag because this greatly confused me when I started Istio.
Our documentation at https://istio.io/docs/setup/kubernetes/quick-start/ says "... HTTP/1.0 is not supported" If we choose NOT to support 1.0, we should add some documentation that if installing Istio causes "426 Upgrade Required" errors for apps using 1.0. Users who hit this will do a web search on the error code, 426, not the problem.
costinm commentedon Feb 19, 2019
Fixed in 1.1
hmakkapati commentedon Mar 20, 2019
Costin's fix: #11511
Sherler commentedon Mar 22, 2019
Is there any instructions or demo to help us enable this feature? @costinm
wu0407 commentedon Nov 25, 2019
istioctl manifest apply --set values.pilot.env.PILOT_HTTP10=1
#13085 (comment)