Skip to content

init container image cannot be changed, is using "latest" tag #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgoeres opened this issue Jun 12, 2020 · 5 comments
Closed

init container image cannot be changed, is using "latest" tag #379

jgoeres opened this issue Jun 12, 2020 · 5 comments

Comments

@jgoeres
Copy link

jgoeres commented Jun 12, 2020

Hi,

I can successfully change the operator, cassandra, and sidecar images to come from our internal registry. Alas, I cannot change the image used as init container, it is always busybox:latest.
While this is "just" the init container, having an external dependency is not nice for prod environments. Further, having "latest" tag gives a bit of "mystery meat" situation (yes, it is "merely" busybox, but still, things can break).

Regards
J

@smiklosovic
Copy link
Collaborator

What would you like to see here? We should create an image just for this container and push it to gcr.io?

@jgoeres
Copy link
Author

jgoeres commented Jun 12, 2020

No, just the option to set the image myself, like I can do with the cassandra and sidecar images. And the pull secret would have to be considered, too, just as it also already works for the other two.
Basically, it could look like this in the CassandraDataCenter spec:

apiVersion: cassandraoperator.instaclustr.com/v1alpha1
kind: CassandraDataCenter
metadata:
[...]
datacenter: dc
cluster: mycluster
spec:
nodes: 1
cassandraImage: myCassandraImage
sidecarImage: mySidecarImage
initContainerImage: myInitContainerImage
imagePullSecrets:
- name: myPullSecret
[...]

@smiklosovic
Copy link
Collaborator

@jgoeres
Copy link
Author

jgoeres commented Jun 12, 2020

@smiklosovic
Thanks again, works perfectly. 👍
If just every open source project had such committed maintainers as you. :-)

@smiklosovic
Copy link
Collaborator

smiklosovic commented Jun 12, 2020

@jgoeres feel free to reach us at Instaclustr, we are always happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants