Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix call Non-static method statically #2788

Merged
merged 5 commits into from Nov 10, 2020
Merged

Conversation

bytehello
Copy link
Contributor

In Hyperf\Di\Aop\PropertyHandlerVisitor method leaveNode modify __construct method,

outout code in runtime/container/proxy/*.proxy.php like below:

use \Hyperf\Di\Aop\PropertyHandlerTrait;
function __construct()
    {
        self::__handlePropertyHandler(__CLASS__);
    }

but in \Hyperf\Di\Aop\PropertyHandlerTrait, __handlePropertyHandler is NON-STATIC method

trait PropertyHandlerTrait
{
    protected function __handlePropertyHandler(string $className)
    {
       ...

Non-static method self::__handlePropertyHandler should not be called statically

fix call Non-static method (__handlePropertyHandler) statically
@limingxinleo
Copy link
Member

what's your php version.

@limingxinleo limingxinleo added the good first issue Good for newcomers label Nov 10, 2020
limingxinleo
limingxinleo previously approved these changes Nov 10, 2020
limingxinleo
limingxinleo previously approved these changes Nov 10, 2020
@limingxinleo limingxinleo merged commit 72fbb8f into hyperf:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants