-
Notifications
You must be signed in to change notification settings - Fork 280
Gradle 5.0 Depreciated API features #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you provide a demo project for us to easily reproduce this issue? |
same/similar issue:
Details:
attached a sample project |
I just wanted to chime in and say we're also getting this warning, and with Gradle 5.0 being released that's a problem. But I'm not sure how to get more info out of Gradle 😄 |
I am seeing a similar-looking issue with Gradle 5.0 and protobuf-gradle-plugin 0.8.7. It is a build error, not a warning, and it is a blocker for me. I need to upgrade to Gradle 5.0 to upgrade to errorprone-gradle-plugin 0.6 to upgrade to Dagger 2.20. It looks like this issue has been around for a while and I hope it can be prioritized. Here's my build output; the various directories correspond to Android productFlavors composing a build variant; I don't think there should be separate directories for these, the only directory needed is
|
Sorry about the slow response. I have just upgraded the build to Gradle 5.0 (#286) and I am working on adding Gradle 5.0 to the tests. While this particular issue is seemingly straightforward to fix, the tests just start to have various failures with the new Gradle version -- probably not due to bugs of the plugin, but due to the way the tests are written and the way dependencies are wired up. It will take some time to clean things up. |
Also facing same problem with Gradle 5.0/5.1. |
Problem persists with Gradle 5.1 and Android Gradle Plugin 3.4.0-alpha10 (latest preview) |
The issue is not an compatibility issue, but rather a functionality issue with Android plugin >= 2.5. The error from Gradle just makes it more obvious. #287 should fix it, and you can find explanation about this issue on that PR. Can any of you check it out, install it locally ( |
@zhangkun83 Worked for me, thank you! |
Facing the same problem. And the build.gradle was worked in version 4.6. Now, my gradle version is 5.1...Is that compatibility problem?
|
you need to use the protobuf plugin in this PR: #287 |
Thanks for reply. I decide to use version 4.10.3 finally. But i wanna make sure it's gonna work for NESTED build right? |
…dle 3.0 in tests. (#287) - `gradle/wrapper/gradle-wrapper.properties`: the Protobuf plugin is now built with Gradle 5.1 - `ProtobufPlugin.groovy`: fixed a bug where GenerateProtoTask may "include" the wrong directory when running with Android plugin >= 2.5. - The bug: `addGenerateProtoTask()` always use the directory per *sourceSet* as input (original line 328), but with Android plugin >= 2.5, the extract task writes to the directory per *variant* (original line 272), thus they don't match. The GenerateProtoTask ends up using a nonexistent directory as an input. We didn't catch it in tests because the integration tests were only run with Android plugin up to 2.3. However, Gradle produced a warning about missing input directory, which becomes an error on Gradle 5.0 (#253). Adding Gradle 5.1 and Android 3.1.0 to the test reproduces this bug. - The fix refactored the file and moved the assigning of inputs closer to where the extract task is created. This makes sure the input of the generate task matches the output of the extract task. - Updated tests - Added Gradle 5.1/Android 3.1.0 to tests, and removed Gradle 2.14.1 the oldest version on the tested list, raising the minimum supported version to Gradle 3.0. Removed code paths dedicated to Gradle <3.0. - Gradle 3.0/Android 2.2.0 is commented out from the list because of gradle/gradle#8158. I have verified this pair passes the tests if it's the only one in the list, presumably bypassing the Gradle issue.
I see that #287 was merged, is there a release scheduled for 0.8.8? ❤️ |
0.8.8 is now released. |
I have the same problem ,Android studio 3.4.1 gradle 5.1.1 ,proto setup |
@douruanliang |
I get this warning using Gradle 4.6 and protobug-gradle-plugin 0.8.6
The text was updated successfully, but these errors were encountered: