Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractorSampleSource should automatically detect the container format #438

Closed
ojw28 opened this issue May 7, 2015 · 5 comments
Closed

ExtractorSampleSource should automatically detect the container format #438

ojw28 opened this issue May 7, 2015 · 5 comments
Assignees
@andrewlewis
Labels
enhancement

Comments

@ojw28
Copy link
Contributor

ojw28 commented May 7, 2015

This makes it possible to avoid having to know the container type up front (which is currently required, since you have to inject the correct Extractor implementation into the ExtractorSampleSource constructor).
@srikieonline
Copy link

+1
Similarly, are there any plans to detect HLS, SS and DASH content upfront - before we parse the manifest and build renderers.

Is there a timeline for auto-detection of container?

@zsmatyas
Copy link
Contributor

+1
I would use it, too!

@ojw28
Copy link
Contributor Author

ojw28 commented Jul 3, 2015

@andrewlewis Is working on the ExtractorSampleSource side of things. Should be implemented relatively soon. We don't have any plans to auto-detect HLS/SS/DASH at this point in time.

@andrewlewis andrewlewis mentioned this issue Jul 6, 2015
Closed
ojw28 added a commit that referenced this issue Jul 21, 2015
@ojw28
Add support for choosing an extractor based on sniffing the container.
85e0bca 
- ExtractorSampleSource takes an array of extractors to test for suitability.
- Extractors now implement a sniff() method that returns whether they can
  extract samples in the input stream's format.
- Switch demo app samples to use format detection.

Issue: #438
@ojw28
Copy link
Contributor Author

ojw28 commented Jul 21, 2015

This is implemented in dev.

@ojw28 ojw28 closed this as completed Jul 21, 2015
@Ood-Tsen
Copy link
Contributor

Excellent !! , it's a huge improved for ExoPlayer.

@LiuDeng LiuDeng mentioned this issue Dec 19, 2015
Closed
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andrewlewis @Ood-Tsen @ojw28 @zsmatyas @srikieonline