Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: add support selecting http version #69

Closed
wants to merge 1 commit into from

Conversation

fcharlie
Copy link

@fcharlie fcharlie commented Nov 7, 2018

Usually we don't need to set libcurl to choose which version of the
HTTP protocol to use to communicate with a server.
But different versions of libcurl, the default value is not the same.

CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS
CURL < 7.62: CURL_HTTP_VERSION_1_1

In order to give users the freedom to control the HTTP version,
we need to add a setting to choose which HTTP version to use.

This patch support force enable HTTP/2 or HTTP/1.1.

example:

GIT_CURL_VERBOSE=1 git2 -c http.version=HTTP/2 ls-remote https://bitbucket.org/aquariusjay/deeplab-public-ver2.git

@fcharlie fcharlie force-pushed the master branch 2 times, most recently from 8b0bead to 4f5a935 Compare November 7, 2018 08:56
@fcharlie
Copy link
Author

fcharlie commented Nov 7, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 7, 2018

An error occurred while submitting:

Error: Permission denied for user fcharlie

@fcharlie
Copy link
Author

fcharlie commented Nov 7, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 7, 2018

An error occurred while submitting:

Error: Permission denied for user fcharlie

@dscho
Copy link
Member

dscho commented Nov 7, 2018

/allow fcharlie

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 7, 2018

User fcharlie is now allowed to use GitGitGadget.

@dscho
Copy link
Member

dscho commented Nov 7, 2018

@fcharlie could you try again, please?

@fcharlie
Copy link
Author

fcharlie commented Nov 7, 2018

/submit

@fcharlie
Copy link
Author

fcharlie commented Nov 7, 2018

@dscho thanks

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 7, 2018

Submitted as pull.69.git.gitgitgadget@gmail.com

@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v2.git.gitgitgadget@gmail.com

@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v3.git.gitgitgadget@gmail.com

@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v4.git.gitgitgadget@gmail.com

@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v5.git.gitgitgadget@gmail.com

@fcharlie fcharlie force-pushed the master branch 2 times, most recently from bc52d2a to 93fda67 Compare November 8, 2018 06:57
@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v6.git.gitgitgadget@gmail.com

@fcharlie
Copy link
Author

fcharlie commented Nov 8, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 8, 2018

Submitted as pull.69.v7.git.gitgitgadget@gmail.com

Usually we don't need to set libcurl to choose which version of the
HTTP protocol to use to communicate with a server.
But different versions of libcurl, the default value is not the same.

CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS
CURL < 7.62: CURL_HTTP_VERSION_1_1

In order to give users the freedom to control the HTTP version,
we need to add a setting to choose which HTTP version to use.

Signed-off-by: Force Charlie <charlieio@outlook.com>
@fcharlie
Copy link
Author

fcharlie commented Nov 9, 2018

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Nov 9, 2018

Submitted as pull.69.v8.git.gitgitgadget@gmail.com

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 14, 2018

This branch is now known as fc/http-version.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 14, 2018

This patch series was integrated into pu via git@5869094.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 14, 2018

This patch series was integrated into next via git@42f5155.

@gitgitgadget

This comment has been minimized.

@gitgitgadget
Copy link

gitgitgadget bot commented Dec 15, 2018

This patch series was integrated into pu via git@4c45cd9.

@gitgitgadget

This comment has been minimized.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 3, 2019

This patch series was integrated into pu via git@b4908f9.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 3, 2019

This patch series was integrated into next via git@56bcbb0.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 4, 2019

This patch series was integrated into pu via git@13d9919.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 4, 2019

This patch series was integrated into next via git@13d9919.

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 4, 2019

This patch series was integrated into master via git@13d9919.

@gitgitgadget gitgitgadget bot added the master label Jan 4, 2019
@gitgitgadget gitgitgadget bot closed this Jan 4, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 4, 2019

Closed via 13d9919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants