Gradle Plugin: Replace execute with finalizedBy #650
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bretthoerner Would you mind merging this PR? I believe many teams already use gradle 5.0 and this fix is required |
|
@bretthoerner Can you please confirm when we should expect this fix to be merged in? We're facing issues with Gradle 5.1. |
|
By the way name of dex task has changed in recent releases of the android gradle plugin. I think we should add the new name in Seems like it fixes #648 too. |
|
@nesterov-n Good catch, you can check out #665? Once I get both of these in and try them I can make a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648 for me.