Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor as visualization #9531

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Editor as visualization #9531

merged 2 commits into from
Mar 27, 2020

Conversation

OlegZharkov
Copy link
Contributor

Implementation of #9352
Current look:
image
Or if you hide tools and history:
image

Works as expected, you can edit your dataset and export its modified version to history (with special characters/tabs/spaces).
You're always welcome to propose changes (maybe background color, should I change it to canonical white?)
Tags are not copied from original file. Does anyone know how to upload file already with tags? At least not an option in upload.xml
Otherwise, feel free to try or just take a look at editor.mako

@galaxybot galaxybot added this to the 20.05 milestone Mar 17, 2020
@anuprulez
Copy link
Member

Do you really have 413 files for this visualisation?

@dannon
Copy link
Member

dannon commented Mar 17, 2020

@anuprulez Looks like it's the build dependencies for the ace editor here; we should be able to repackage that like the other visualizations have been done recently, and rebase out the static files. I can help follow up on that. (not a big deal, though -- and this is very cool @OlegZharkov!)

@simonbray
Copy link
Member

This looks awesome Oleg, thanks a lot!

I am more in favour of the white background, I think it fits better with the rest of the Galaxy colour scheme.

@OlegZharkov
Copy link
Contributor Author

@anuprulez yeah, that was ace-editor. It took me a little while, but everything is squeezed in single script.js file with webpack. File structure should look way better now.

@simonbray so I changed backgroud color to white
image
Export button is semi-transparent, but it will be highlighted on hover

@dannon do you know if it's possible to preserve tag? Do we actually need this feature?

If someone wants to try it locally, you would need to run this now:

cd galaxy/config/plugins/visualizations/editor
npm install
npm run build

and then standart make client at galaxy root dir

Thanks a lot for testing!

@simonbray
Copy link
Member

@OlegZharkov, thanks, looks better than the dark theme IMO. Is it possible to make the export button a bit more visible against the white background?

@OlegZharkov
Copy link
Contributor Author

@simonbray sure, it's possible. But the idea was to make it semi-transparent, so it will not cover the text behind it. Example:
image

To avoid confusion, it's highlighted if you hover the mouse

image

@OlegZharkov OlegZharkov force-pushed the editor-vis branch 6 times, most recently from ce3bb71 to 6ef0983 Compare March 25, 2020 18:18
intoduce webpack, remove ace-editor files from static

fix lint

build editor automatically

remove package lock
@OlegZharkov
Copy link
Contributor Author

I guess, we are good to go here. A huge thanks to @dannon and @mvdbeek!
@simonbray I will create another PR to EU after it gets merged

Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlegZharkov Thanks for the work on this, it looks great, and it's working well for me!

@dannon dannon merged commit ebfe0b5 into galaxyproject:dev Mar 27, 2020
@OlegZharkov
Copy link
Contributor Author

@dannon
Thanks a lot !!

@simonbray
Copy link
Member

Thanks everyone!

@OlegZharkov
Copy link
Contributor Author

@simonbray I guess, you can close #9352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants