-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor as visualization #9531
Editor as visualization #9531
Conversation
Do you really have |
@anuprulez Looks like it's the build dependencies for the ace editor here; we should be able to repackage that like the other visualizations have been done recently, and rebase out the static files. I can help follow up on that. (not a big deal, though -- and this is very cool @OlegZharkov!) |
This looks awesome Oleg, thanks a lot! I am more in favour of the white background, I think it fits better with the rest of the Galaxy colour scheme. |
@anuprulez yeah, that was ace-editor. It took me a little while, but everything is squeezed in single @simonbray so I changed backgroud color to white @dannon do you know if it's possible to preserve tag? Do we actually need this feature? If someone wants to try it locally, you would need to run this now:
and then standart Thanks a lot for testing! |
@OlegZharkov, thanks, looks better than the dark theme IMO. Is it possible to make the export button a bit more visible against the white background? |
@simonbray sure, it's possible. But the idea was to make it semi-transparent, so it will not cover the text behind it. Example: To avoid confusion, it's highlighted if you hover the mouse |
ce3bb71
to
6ef0983
Compare
intoduce webpack, remove ace-editor files from static fix lint build editor automatically remove package lock
I guess, we are good to go here. A huge thanks to @dannon and @mvdbeek! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlegZharkov Thanks for the work on this, it looks great, and it's working well for me!
@dannon |
Thanks everyone! |
@simonbray I guess, you can close #9352 |
Implementation of #9352


Current look:
Or if you hide tools and history:
Works as expected, you can edit your dataset and export its modified version to history (with special characters/tabs/spaces).
You're always welcome to propose changes (maybe background color, should I change it to canonical white?)
Tags are not copied from original file. Does anyone know how to upload file already with tags? At least not an option in upload.xml
Otherwise, feel free to try or just take a look at
editor.mako