Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations guide for Localized CupertinoTabBar Semantics #3996

Merged
merged 8 commits into from May 8, 2020
Merged

Migrations guide for Localized CupertinoTabBar Semantics #3996

merged 8 commits into from May 8, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 24, 2020

This a migration guide for flutter/flutter#55336

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 24, 2020
@Piinks Piinks requested a review from sfshaza2 April 24, 2020 19:26
sfshaza2
sfshaza2 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx!

@sfshaza2
Copy link
Contributor

Actually, I rescind my LGTM. I was too quick. :D

There are two issues:`

  • Delete the ".md" extension from the URL in the index file. It's the reason that Travis broke.
  • We can't land these breaking change docs until we know in which build they have landed. The PR is still open, so this can't be merged.

@sfshaza2 sfshaza2 changed the title Migrations guide for Localized CupertinoTabBar Semantics [WIP] Migrations guide for Localized CupertinoTabBar Semantics Apr 24, 2020
@Piinks
Copy link
Contributor Author

Piinks commented May 1, 2020

This change has landed, just waiting for the build tag. :)

@sfshaza2
Copy link
Contributor

sfshaza2 commented May 6, 2020

I see that this landed in 1.18.0. (The actual version is 1.18.0-10.0.pre.) Can we finish up this PR, @Piinks?

@Piinks
Copy link
Contributor Author

Piinks commented May 6, 2020

I see that this landed in 1.18.0. (The actual version is 1.18.0-10.0.pre.) Can we finish up this PR, @Piinks?

All set! :)

@Piinks Piinks changed the title [WIP] Migrations guide for Localized CupertinoTabBar Semantics Migrations guide for Localized CupertinoTabBar Semantics May 6, 2020
@Piinks
Copy link
Contributor Author

Piinks commented May 6, 2020

@sfshaza2 it looks like this is failing on Travis from an unrelated change?

@Piinks Piinks changed the title Migrations guide for Localized CupertinoTabBar Semantics WIP Migrations guide for Localized CupertinoTabBar Semantics May 7, 2020
@Piinks Piinks added the st.WIP Issue in progress label May 7, 2020
@Piinks
Copy link
Contributor Author

Piinks commented May 7, 2020

I need to add mention of the hint changing, per flutter/flutter#56582

@sfshaza2 sfshaza2 changed the title WIP Migrations guide for Localized CupertinoTabBar Semantics Migrations guide for Localized CupertinoTabBar Semantics May 8, 2020
@sfshaza2 sfshaza2 removed the st.WIP Issue in progress label May 8, 2020
@sfshaza2 sfshaza2 merged commit e9589b4 into flutter:master May 8, 2020
@Piinks
Copy link
Contributor Author

Piinks commented May 8, 2020

This was not ready to be merged. I'll open a new PR to update.

@Piinks Piinks mentioned this pull request May 8, 2020
Merged
@Piinks Piinks mentioned this pull request Jun 5, 2020
Closed
Piinks
Piinks commented Jun 12, 2020
View reviewed changes
Copy link
Contributor Author

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change has been tagged with a build now, so this is ready to go with your approval.

@Piinks
Copy link
Contributor Author

Piinks commented Jun 12, 2020

whoops, wrong pr! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Piinks @sfshaza2 @googlebot