Skip to content

Change --disable-dds to --no-dds to avoid double negatives #80900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 21, 2021

Also, refactor internal code to do the same.

See https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis

This is part of #76271

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Sorry, something went wrong.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@Hixie Hixie force-pushed the tool_arg_todos branch 2 times, most recently from 6f583bc to affa5e8 Compare April 22, 2021 17:48
@zanderso
Copy link
Member

Google testing test failures are related.

@Hixie
Copy link
Contributor Author

Hixie commented Apr 22, 2021

Yeah I need to make sure we don't print the deprecation warning in --machine mode.

@Hixie Hixie force-pushed the tool_arg_todos branch 3 times, most recently from 7edf3d5 to 25e3c9e Compare April 22, 2021 22:44
@Hixie
Copy link
Contributor Author

Hixie commented Apr 22, 2021

I've disabled the deprecation warning code for now.

@Hixie Hixie force-pushed the tool_arg_todos branch 2 times, most recently from dd9950e to 48d6749 Compare April 23, 2021 19:36
@Hixie Hixie merged commit e541469 into flutter:master Apr 23, 2021
@Hixie Hixie deleted the tool_arg_todos branch April 23, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants