Remove nullOk from Actions.invoke, add Actions.maybeInvoke #74680
+132
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the
nullOk
parameter fromActions.invoke
, and adds anActions.maybeInvoke
function. The difference is that invoke will now always (in debug mode) throw if an enabled action isn't found, andmaybeInvoke
will return null if an enabled action isn't found. Theinvoke
function can still return null as the result of the invocation, though, so I purposely didn't change the return value toObject
fromObject?
.Related Issues
Tests
maybeInvoke
, updatedinvoke
tests.Breaking Change