Remove vestigial nullOk parameter from Localizations.localeOf #74657
+19
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: internationalization
|
Looks like flutter_svg's hash needs to be updated in the tests repository to pick up the removal of nullOK in that package: https://github.com/flutter/tests/blob/master/registry/flutter_svg.test#L3 |
gspencergoog
added a commit
to flutter/tests
that referenced
this pull request
Jan 25, 2021
So that I can land flutter/flutter#74657
gspencergoog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the
nullOkparameter on theLocalizations.localeOfmethod. This was already changed to have amaybeLocaleOfmethod, but thenullOkparameter wasn't removed because some third party tests failed. Those have been updated, so this can go in now.Related Issues
Tests
Breaking Change