Remove span deprecations #73747
Merged
Remove span deprecations #73747
+9
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
framework
darrenaustin
approved these changes
Jan 12, 2021
| /// replacement character (0xFFFC) that is inserted to represent it. | ||
| /// | ||
| /// Any [GestureRecognizer]s are added to `semanticsElements`. Null is added to | ||
| /// `semanticsElements` for [PlaceholderSpan]s. |
There was a problem hiding this comment.
Is the @override no longer needed here? or is this an oversight?
There was a problem hiding this comment.
No longer needed. :)
|
This is waiting on a change migrating internal customers. |
|
Customers are migrated, this is good to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecations in the
InlineSpan,TextSpan, andPlaceholderSpanclasses that have reached the EOL . HEre is a table to reference the migrations for each:Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime
More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad
Related Issues
Deprecated in #34051
#73910
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.