Skip to content

Remove deprecated Element methods #72903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 22, 2021
Merged

Remove deprecated Element methods #72903

merged 7 commits into from
Jan 22, 2021
+203 −130

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 23, 2020 •
edited
Loading

Description

This removes the deprecated Element methods that has reached the EOL . See table below:

Before After
inheritFromElement dependOnInheritedElement
inheritFromWidgetOfExactType dependOnInheritedWidgetOfExactType
ancestorInheritedElementForWidgetOfExactType getElementForInheritedWidgetOfExactType
ancestorWidgetOfExactType findAncestorWidgetOfExactType
ancestorStateOfType findAncestorStateOfType
rootAncestorStateOfType findRootAncestorStateOfType
ancestorRenderObjectOfType findAncestorRenderObjectOfType

Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime

More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad

Related Issues

Deprecated in #44189
#73910

Tests

Tests for quick fix tool.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

Sorry, something went wrong.

@Piinks
Remove deprecated Element methods.

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 5B3FBDB4FD74402C
Learn about vigilant mode
a276038
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Dec 23, 2020
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 23, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@Piinks Piinks requested a review from goderbauer December 23, 2020 23:57
@Piinks Piinks mentioned this pull request Dec 23, 2020
Merged
9 tasks
@Piinks
Copy link
Contributor Author

Piinks commented Dec 23, 2020

Dependent on #69620

goderbauer
goderbauer reviewed Jan 5, 2021
View reviewed changes
Piinks added 2 commits January 5, 2021 15:19
@Piinks
Merge branch 'master' of github.com:flutter/flutter into elementDeps

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 5B3FBDB4FD74402C
Learn about vigilant mode
9f41907
@Piinks
++
171bfdd
Piinks
Piinks commented Jan 5, 2021
View reviewed changes
@Piinks Piinks requested a review from goderbauer January 5, 2021 22:00
@goderbauer
Copy link
Member

Something made the tests very unhappy.

@goderbauer
Copy link
Member

Oh, probably because it depends on that other PR. Nevermind.

goderbauer
goderbauer approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks mentioned this pull request Jan 11, 2021
Merged
9 tasks
@Piinks
Copy link
Contributor Author

Piinks commented Jan 12, 2021 •
edited
Loading

Waiting on the next roll to be completed before landing this. All of the current G failures here should be resolved by the roll.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Jan 14, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Jan 21, 2021

This is waiting on migration of internal customers.

@Piinks
Copy link
Contributor Author

Piinks commented Jan 21, 2021

Migration completed, good to land.

@fluttergithubbot fluttergithubbot merged commit 550a85d into flutter:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer

Assignees
No one assigned
Labels
c: API break Backwards-incompatible API changes f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Piinks @goderbauer @fluttergithubbot