Remove deprecated Scaffold.resizeToAvoidBottomPadding #72890
Merged
+35
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
goderbauer
reviewed
Jan 6, 2021
| // Change made in https://github.com/flutter/flutter/pull/15303 | ||
| showDialog(builder: (context) => Text('Fix me.')); | ||
|
|
There was a problem hiding this comment.
nit: Why's there an empty line here?
There was a problem hiding this comment.
Oh that must be a merge artifact. Nice catch!
Piinks
commented
Jan 7, 2021
|
This pull request is not suitable for automatic merging in its current state.
|
|
This pull request is not suitable for automatic merging in its current state.
|
|
I have verified the google failures are unrelated and that everything passes. Manually setting the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecated
Scaffold.resizeToAvoidBottomPaddingparameter that has reached the EOL . TheresizeToAvoidBottomInsetproperty should be used instead.Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime
More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad
Related Issues
Deprecated in #26259
#73910
Tests
Tests for quick fix tool.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.