Skip to content

Remove deprecated showDialog.child #72532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 23, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 17, 2020

Description

This removes the deprecated showDialog.child parameter that has reached the EOL . The builder property should be used instead.

Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime

More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad

Related Issues

Deprecated in #15303

Tests

Tests for quick fix tool.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 17, 2020
@google-cla google-cla bot added the cla: yes label Dec 17, 2020
Nit

Unverified

This user has not yet uploaded their public signing key.
@Piinks Piinks added the c: API break Backwards-incompatible API changes label Dec 17, 2020
@Piinks Piinks requested a review from goderbauer December 17, 2020 18:26
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Contributor Author

Piinks commented Dec 23, 2020

@renyou is it safe to land this? I created a fix, and everything appears to pass. It isn't updating here though.

@renyou
Copy link
Contributor

renyou commented Dec 23, 2020

@renyou is it safe to land this? I created a fix, and everything appears to pass. It isn't updating here though.

Looks like the something is stuck. Let me kick start a new test. Shouldn't take too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: API break Backwards-incompatible API changes f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants