-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Solve the problem when a textField sets inputFormatters #69553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hi @Shadow-NewBee thanks for the PR! For this PR to be reviewed/submitted you must provide tests to guard against future regressions (instructions can be found here: https://github.com/flutter/flutter/wiki/Running-and-writing-tests). Also we should probably not prevent all |
@Shadow-NewBee Do you have plans to follow up soon-ish on the feedback provided above? |
Yeah, But I had trouble to make test, in addition, some default checks such as Mac framework_tests showed failed, but I do not how to fix it. |
@Shadow-NewBee Thanks for the contribution! I was wondering if this fix can directly lands on the formatter. |
Also you need to update the checklist if you can follow up the feedback |
This behavior breaks some tests so the framework tests failed. One of the failing test's log:
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I am going to close this one for now. If you have time to address the feedback feel free to re-open. |
Description
Solve the problem when a textField sets inputFormatters such as FilteringTextInputFormatter.allow(RegExp('[a-zA-Z0-9]')), then user input word with Chinese Pinyin Keyboard, the composing letters will be formate. The problem show in Rateted Issue, there is a gif.
Related Issues
Tests
I added the following tests:
Checklist
///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change