Remove nullOk parameter from Shortcuts.of, Actions.find, and Actions.handler #68921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the
nullOk
parameter fromShortcuts.of
,Actions.find
andActions.handler
and createdShortcuts.maybeOf
andActions.maybeFind
.Shortcuts.of
andActions.find
now return non-nullable values, and themaybe
versions return a nullable value. I didn't create a non-nullable version ofActions.handler
, since it needs to be able to return null if an action is not enabled, but I did remove thenullOk
parameter, effectively setting it totrue
permanently, since setting it to false doesn't make much sense if the function can still return null when the action is not enabled.Related Issues
Tests
maybeOf
appropriately, added tests forShortcuts.of
andShortcuts.maybeOf
.Breaking Change