Skip to content

Remove nullOk from Scaffold.of and ScaffoldMessenger.of, create maybeOf for both #68908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Remove nullOk from Scaffold.of and ScaffoldMessenger.of, create maybeOf for both #68908

merged 1 commit into from
Oct 29, 2020
+105 −68

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 23, 2020 •
edited
Loading

Description

This removes the nullOk parameter from Scaffold.of and ScaffoldMessenger.of, and creates Scaffold.maybeOf and ScaffoldMessenger.maybeOf. Scaffold.of and ScaffoldMessenger.of now both return non-nullable values, and the maybeOf equivalents return nullable values.

Related Issues

Tests

  • Updated tests to not need ! anymore.

Breaking Change

Sorry, something went wrong.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@gspencergoog gspencergoog marked this pull request as ready for review October 27, 2020 22:53
@gspencergoog gspencergoog requested a review from Piinks October 27, 2020 22:53
Piinks
Piinks approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is awesome! So many !s

@gspencergoog gspencergoog merged commit 4fa5fe5 into flutter:master Oct 29, 2020
@MichalTorma MichalTorma mentioned this pull request Nov 4, 2020
Closed
@rydmike rydmike mentioned this pull request Jan 22, 2021
Closed
@gspencergoog gspencergoog deleted the remove_null_ok_3 branch October 7, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gspencergoog @Piinks