Remove nullOk parameter from Cupertino color resolution APIs
#68905
+166
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
gspencergoog
force-pushed
the
remove_null_ok_2
branch
from
c29fe74 to
0098e22
Compare
gspencergoog
force-pushed
the
remove_null_ok_2
branch
from
0098e22 to
bb571de
Compare
|
This currently contains the changes also in #68905 Once that lands, I'll rebase this and take it off of draft status. |
gspencergoog
force-pushed
the
remove_null_ok_2
branch
3 times, most recently
from
53142c5 to
fbebac6
Compare
|
Rebased and ready for review now. This does slightly change the mechanics of these functions: specifying Let me know if that seems like a bad idea... |
LongCatIsLooong
approved these changes
Oct 29, 2020
gspencergoog
force-pushed
the
remove_null_ok_2
branch
from
fbebac6 to
2fde09f
Compare
gspencergoog
force-pushed
the
remove_null_ok_2
branch
from
2fde09f to
641f566
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the
nullOkparameter from the Cupertino color resolution APIs. It changes the behavior ofCupertinoDynamicColor.resolveFromto not throw if the context does not contain the required dependencies, which was the default (and was only set to throw in a test). This allows a cascade of being able to remove thenullOkparameter from several other APIs, where they didn't actually return nullable values anyhow, it just indicated that the throwing behavior would be enabled if set to false, which made it a pretty confusing name.Related Issues
Tests
Breaking Change