Autofill Part 1 #52126

LongCatIsLooong · 2020-03-06T18:10:27Z

Description

iOS PR: flutter/engine#17493
Android PR: flutter/engine#17465
Design Doc: https://flutter.dev/go/input-field-autofill

Scope

This PR (as well as the engine PRs) adds the most basic autofill functionality. It does not include some platform-specific configurations (e.g., passwordRules on iOS).

Example Usage:

  @override
  Widget build(BuildContext context) {
    return AutofillGroup(
      child: Column(
        children: <Widget>[
          TextField(controller: username, autofillHints: [AutofillHints.username]),
          Checkbox(
            value: isNewUser,
            onChanged: (bool newValue) {
              setState(() { isNewUser = newValue; });
            },
          ),
          if (isNewUser) TextField(controller: newPassword, autofillHints: [AutofillHints.newPassword]),
          if (isNewUser) TextField(ontroller: repeatNewPassword, autofillHints: [AutofillHints.newPassword]),
          if (!isNewUser) TextField(controller: password, autofillHints: [AutofillHints.password]),
        ],
      ),
    );
  }

Related Issues

Part of #13015

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/input-field-autofill
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: Replace with a link to your migration guide

goderbauer · 2020-03-09T17:35:47Z

Why does the Autofill widget need to take a builder instead of just a list of controllers?

LongCatIsLooong · 2020-03-09T18:51:46Z

@goderbauer the controllers in the list may change as the state of the form changes. In most cases it should simply follow the logic in the build method.

goderbauer · 2020-03-09T19:36:27Z

If the controllers change, wouldn't you have to call setState anyways to assign those new controllers to the textfields? When you do that, the Autofill would also rebuild with the new list of controllers.

LongCatIsLooong · 2020-03-09T20:07:38Z

Then in that case the list of controllers will be updated in the next build phase? If the state has already changed and the scope queries the list of controllers before the next build phase, the list we return should reflect the new state I think?

LongCatIsLooong · 2020-03-11T22:36:21Z

examples/flutter_gallery/lib/demo/material/text_form_field_demo.dart

-                      hintText: 'What do people call you?',
-                      labelText: 'Name *',
+                  // Since the fields are in a Column, it's easier to
+                  // uses the non-lazy version.


In this case since we're using a Column, we can just wrap the entire Column inside an Autofill and omit clientListBuilder

examples/flutter_gallery/lib/demo/material/text_form_field_demo.dart

justinmc · 2020-04-13T22:51:35Z

packages/flutter/lib/src/widgets/autofill.dart

+///
+/// {@template flutter.widgets.autofill.AutofillGroupState}
+/// An [AutofillGroupState] can be used to register an [AutofillClient] when it
+/// enteres this [AutofillGroup] (for example, when an [EditableText] is mounted or


"enteres" => "enters"

justinmc · 2020-04-13T22:52:29Z

packages/flutter/test/widgets/autofillgroup_test.dart

@@ -0,0 +1,166 @@
+// Copyright 2014 The Flutter Authors. All rights reserved.


This file's name is missing an underscore, should be: autofill_group_test.dart

goderbauer

I like the new registration-based approach.

goderbauer · 2020-04-13T23:15:02Z

packages/flutter/lib/src/services/text_input.dart

+    if (method == 'TextInputClient.updateEditingStateWithTag') {
+      final TextInputClient client = _currentConnection._client;
+      assert(client != null);
+      if (client is AutofillTrigger) {


Should all TextInputClient just have a currentAutofillScope getter and return null by default if they don't participate in AutoFill? (Not sure what the AutofillTrigger abstraction is adding)

Functionality-wise I think it's the same. Adding AutofillTrigger makes it non-breaking?

I just landed a very similar breaking change a few days ago. I think that makes breaking this less bad?

I think I would prefer the cleaner API here without the type check. Implementing your own TextInputClient should be fairly un-common, so migration should be fairly easy?

goderbauer · 2020-04-13T23:16:47Z

packages/flutter/lib/src/widgets/autofill.dart

+
+  /// Adds the [AutofillClient] to this [AutofillGroup].
+  ///
+  /// Typically, this is be called by [AutofillTrigger]s (for example,


nit: remove the "be"?

BirjuVachhani · 2020-04-30T10:23:00Z

Can anyone tell me which version has these changes or is this hasn't been released yet?

hpoul · 2020-05-04T13:31:05Z

@BirjuVachhani simply check the merge commit e31f708 which will show you all tags it is in, right now: "1.18.0-8.0.pre 1.18.0-7.0.pre 1.18.0-6.0.pre" - ie. already in the dev channel.

BirjuVachhani · 2020-05-05T05:46:45Z

@hpoul Thank you for the info. I did check it out and I got those changes. However I was wondering about the same in a TextFormField. Any info on that would be helpful. Thanks.

LongCatIsLooong · 2020-05-06T03:31:16Z

@hpoul @BirjuVachhani one of the commits was reverted as part of the engine roll revert, it's probably not working on android. I'll post updates in the related issue thread and hopefully close that issue soon.

BirjuVachhani · 2020-05-06T03:56:57Z

@LongCatIsLooong got it. Thank you for the info. 😊

pokonski · 2020-05-06T12:30:00Z

Which one is the related issue? 🤔

akshaybengani · 2020-06-05T14:21:47Z

Thank you very much, I was totally freaked out for such a solution, it is working properly just upgrade the flutter to master and that's it, even one-time password is also working.

Thank you once again you saved my ass.

nausharipov · 2020-06-11T10:01:25Z

How to invoke a prompt for saving the new username and password? I've wrapped textfields into autofillgroup, now the passwords are shown but the current is not saved

nturgut · 2020-06-11T17:08:29Z

@nausharipov Thanks for asking! We are still working on that part. The tracking issue: #55613

fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Mar 6, 2020

googlebot added the cla: yes label Mar 6, 2020

LongCatIsLooong commented Mar 11, 2020

View reviewed changes

nturgut reviewed Mar 11, 2020

View reviewed changes

examples/flutter_gallery/lib/demo/material/text_form_field_demo.dart Outdated Show resolved Hide resolved

LongCatIsLooong force-pushed the autofill-controller-list branch 5 times, most recently from 6bcb4f7 to 2cf28ff Compare March 13, 2020 08:23

LongCatIsLooong changed the title ~~[WIP please do not review] Autofill with Controller list~~ [WIP] Autofill with Controller list Mar 18, 2020

LongCatIsLooong force-pushed the autofill-controller-list branch from 6133e83 to 87af84f Compare March 24, 2020 18:24

LongCatIsLooong changed the title ~~[WIP] Autofill with Controller list~~ Autofill with Controller list Mar 24, 2020

fluttergithubbot added the f: cupertino flutter/packages/flutter/cupertino repository label Mar 24, 2020

LongCatIsLooong force-pushed the autofill-controller-list branch from 2bbf2da to 89ee788 Compare March 24, 2020 22:21

LongCatIsLooong changed the title ~~Autofill with Controller list~~ Autofill Part 1 Mar 24, 2020

This was referenced Apr 2, 2020

Android Autofill flutter/engine#17465

Merged

Add autofill support to ios text input plugin flutter/engine#17493

Merged

LongCatIsLooong force-pushed the autofill-controller-list branch 2 times, most recently from cac5fa1 to 8b11268 Compare April 3, 2020 16:52

rebase

af1e1f9

LongCatIsLooong force-pushed the autofill-controller-list branch from 8b11268 to af1e1f9 Compare April 3, 2020 17:20

justinmc reviewed Apr 13, 2020

View reviewed changes

goderbauer reviewed Apr 13, 2020

View reviewed changes

typo

368d09c

LongCatIsLooong force-pushed the autofill-controller-list branch 2 times, most recently from 370190d to e88c584 Compare April 14, 2020 18:32

remove AutofillTrigger

1260a80

LongCatIsLooong force-pushed the autofill-controller-list branch from e88c584 to 1260a80 Compare April 16, 2020 19:27

nturgut mentioned this pull request Apr 17, 2020

[web] new text editing method. flutter/engine#17771

Merged

LongCatIsLooong added the waiting for tree to go green label Apr 20, 2020

fluttergithubbot merged commit e31f708 into flutter:master Apr 20, 2020

LongCatIsLooong deleted the autofill-controller-list branch April 20, 2020 21:53

SebastianKlaiber mentioned this pull request Jul 20, 2020

Feature request: Autofill Support GiancarloCode/form_bloc#135

Closed

github-actions bot mentioned this pull request Aug 10, 2020

Flutter 1.20正式发布，新特性解读！ duty-machine/duty-machine#743

Closed

falkorichter mentioned this pull request Aug 18, 2020

1 password integration apiraino/open-taffeta-mobile-app#30

Draft

BreX900 mentioned this pull request Oct 22, 2020

Add support for autofillHints in TextField GiancarloCode/form_bloc#185

Closed

LongCatIsLooong mentioned this pull request Nov 2, 2020

[iOS] adding autoFillHint to TextFormField breaks FocusScope.of(context).nextFocus() #66144

Closed

hello-addweb mentioned this pull request Dec 11, 2020

Autofillgroup does not trigger save credentials #72083

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autofill Part 1 #52126

Autofill Part 1 #52126

LongCatIsLooong commented Mar 6, 2020 •

edited

goderbauer commented Mar 9, 2020

LongCatIsLooong commented Mar 9, 2020

goderbauer commented Mar 9, 2020

LongCatIsLooong commented Mar 9, 2020

LongCatIsLooong Mar 11, 2020 •

edited

justinmc Apr 13, 2020

justinmc Apr 13, 2020

goderbauer left a comment

goderbauer Apr 13, 2020

LongCatIsLooong Apr 13, 2020

LongCatIsLooong Apr 14, 2020

goderbauer Apr 14, 2020

goderbauer Apr 13, 2020

BirjuVachhani commented Apr 30, 2020

hpoul commented May 4, 2020

BirjuVachhani commented May 5, 2020

LongCatIsLooong commented May 6, 2020 •

edited

BirjuVachhani commented May 6, 2020

pokonski commented May 6, 2020

akshaybengani commented Jun 5, 2020

nausharipov commented Jun 11, 2020

nturgut commented Jun 11, 2020

		@@ -0,0 +1,166 @@
		// Copyright 2014 The Flutter Authors. All rights reserved.

Autofill Part 1 #52126

Autofill Part 1 #52126

Conversation

LongCatIsLooong commented Mar 6, 2020 • edited

Description

Scope

Example Usage:

Related Issues

Tests

Checklist

Breaking Change

goderbauer commented Mar 9, 2020

LongCatIsLooong commented Mar 9, 2020

goderbauer commented Mar 9, 2020

LongCatIsLooong commented Mar 9, 2020

LongCatIsLooong Mar 11, 2020 • edited

Choose a reason for hiding this comment

justinmc Apr 13, 2020

Choose a reason for hiding this comment

justinmc Apr 13, 2020

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

goderbauer Apr 13, 2020

Choose a reason for hiding this comment

LongCatIsLooong Apr 13, 2020

Choose a reason for hiding this comment

LongCatIsLooong Apr 14, 2020

Choose a reason for hiding this comment

goderbauer Apr 14, 2020

Choose a reason for hiding this comment

goderbauer Apr 13, 2020

Choose a reason for hiding this comment

BirjuVachhani commented Apr 30, 2020

hpoul commented May 4, 2020

BirjuVachhani commented May 5, 2020

LongCatIsLooong commented May 6, 2020 • edited

BirjuVachhani commented May 6, 2020

pokonski commented May 6, 2020

akshaybengani commented Jun 5, 2020

nausharipov commented Jun 11, 2020

nturgut commented Jun 11, 2020

LongCatIsLooong commented Mar 6, 2020 •

edited

LongCatIsLooong Mar 11, 2020 •

edited

LongCatIsLooong commented May 6, 2020 •

edited