Reland "Do not rebuild Routes when a new opaque Route is pushed on top" #49376
+717
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: cupertino
|
@dkwingsmt for review of the changes to the stepper test: https://github.com/flutter/flutter/pull/49376/files#diff-cf08a14b525117a713c3170d35000be3 |
dkwingsmt
approved these changes
Jan 23, 2020
goderbauer
force-pushed
the
revert-49366-revert-48900-theatre2
branch
from
49be385 to
18020a9
Compare
|
This should not be submitted until the upstream fixes have been submitted to the internal google code base. |
goderbauer
force-pushed
the
revert-49366-revert-48900-theatre2
branch
from
18020a9 to
97cfd7a
Compare
goderbauer
added
waiting for tree to go green
and removed
f: cupertino
|
Upstream fixes are in, this is ready for submission when Cirrus is done. |
jonahwilliams
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
7 tasks
ds84182
added a commit
that referenced
this pull request
Feb 7, 2020
Before, active overlays used the TickerMode of the tree above their parent Overlay widget. This worked nicely with nested Overlays/Navigators, because all animations could be disabled at by the topmost navigator. After the change, a regression was introduced where Overlays that were offstage (inside of another Overlay) would continue ticking, consuming CPU and GPU time for animations that wouldn't be seen.
liyuqian
added
perf: speed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #48900 for full description of this change.
The reason for the revert turned out to be erroneous user code that was missing setState calls. The code was instead relying on the implicit rebuilds caused by pushing/popping routes which this PR removes. The google-internal tests in question have been fixed.
Reverts #49366
Migration guide: flutter/website#3581