-
Notifications
You must be signed in to change notification settings - Fork 28.7k
iOS 13 scrollbar vibration #37724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 13 scrollbar vibration #37724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this still working? |
@valeriylu It seems to work for me, I just tried this on my iPhone 7 running iOS 13 on Flutter's latest master. I long pressed on the scrollbar thumb. Here's the code I used: import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return CupertinoApp(
title: 'Cupertino App',
home: CupertinoPageScaffold(
child: CupertinoScrollbar(
child: ListView.builder(
itemCount: 100,
itemBuilder: (BuildContext context, int index) {
return Card(
child: Text('child #$index'),
);
},
),
),
),
);
}
} |
@justinmc |
Ah got it. |
Description
It was pointed out that the recent implementation of draggable scrollbars doesn't include the vibration feedback that native iOS 13 does. This PR adds the vibration.
Related Issues
#37724
#35127
Tests
I tested that exactly one vibration happens at the start of both types of scrollbar dragging.