Skip to content

Let the Android embedding adopt OnPreDrawListener #85292

@xster

Description

@xster
Member

Internal bugs: http://b/190767277, http://b/185423816

Using https://developer.android.com/reference/android/view/ViewTreeObserver.OnPreDrawListener to delay when Flutter's activity first draws can help solve

Things this might involve:

Activity

added
c: new featureNothing broken; request for a new capability
platform-androidAndroid applications specifically
engineflutter/engine repository. See also e: labels.
c: performanceRelates to speed or footprint issues (see "perf:" labels)
a: fidelityMatching the OEM platforms better
on Jun 25, 2021
blasten

blasten commented on Jun 25, 2021

@blasten

@jiahaog any updates on this issue? Let me know if you want me to take a look, and go ahead with the PR.

xster

xster commented on Jun 25, 2021

@xster
MemberAuthor

One consideration to make though wrt #85139 is that it still can't make Android's first frame a correct measurement of Flutter's first frame, since Android's first frame will still be

[Flutter's first frame] + [time needed to jump from raster to main thread and get a next Android vsync] = [Android's first frame].

jiahaog

jiahaog commented on Jun 28, 2021

@jiahaog
Member

Yes, I've started looking at it, will follow up with a PR soon

added
P3Issues that are less important to the Flutter project
on Jun 28, 2021
added and removed
P3Issues that are less important to the Flutter project
on Jun 28, 2021

15 remaining items

jiahaog

jiahaog commented on Jul 20, 2021

@jiahaog
Member

Update: Working on a PR for what was discussed above

chinmaygarde

chinmaygarde commented on Aug 2, 2021

@chinmaygarde
Member

@jiahaog flutter/engine#27811 seems to have landed. Can we close this issue?

blasten

blasten commented on Aug 2, 2021

@blasten

I think so

github-actions

github-actions commented on Aug 16, 2021

@github-actions

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

locked as resolved and limited conversation to collaborators on Aug 16, 2021
added
P0Critical issues such as a build break or regression
and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressiona: fidelityMatching the OEM platforms betterc: new featureNothing broken; request for a new capabilityc: performanceRelates to speed or footprint issues (see "perf:" labels)customer: money (g3)engineflutter/engine repository. See also e: labels.platform-androidAndroid applications specifically

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @chinmaygarde@xster@blasten@jiahaog@jonahwilliams

      Issue actions

        Let the Android embedding adopt OnPreDrawListener · Issue #85292 · flutter/flutter