Skip to content

Revise CupertinoColors and CupertinoTheme for dynamic colors #35541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
26 of 27 tasks
LongCatIsLooong opened this issue Jul 3, 2019 · 2 comments
Closed
26 of 27 tasks

Revise CupertinoColors and CupertinoTheme for dynamic colors #35541

LongCatIsLooong opened this issue Jul 3, 2019 · 2 comments
Assignees
@LongCatIsLooong
Labels
c: new feature Nothing broken; request for a new capability f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Comments

@LongCatIsLooong
Copy link
Contributor

LongCatIsLooong commented Jul 3, 2019 •
edited
Loading

Determine whether/how we should adopt dynamic colors.

Progress

Nice to have

- [ ] https://github.com/flutter/flutter/pull/41859/files#r331609336 MORE ASSERTS, e.g. if a CupertinoDynamicColor is used to paint before being resolved. Can't because that will break people using CupertinoColors.activeBlue
@LongCatIsLooong LongCatIsLooong self-assigned this Jul 3, 2019
@shihaohong shihaohong added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jul 3, 2019
@LongCatIsLooong LongCatIsLooong mentioned this issue Aug 6, 2019
Merged
8 tasks
This was referenced Aug 25, 2019
Merged
Merged
This was referenced Sep 3, 2019
Merged
Merged
Merged
This was referenced Sep 10, 2019
Merged
Merged
Merged
Merged
This was referenced Sep 27, 2019
Merged
Merged
@iapicca iapicca mentioned this issue Oct 24, 2019
Closed
@LongCatIsLooong LongCatIsLooong mentioned this issue Oct 30, 2019
Merged
9 tasks
@LongCatIsLooong LongCatIsLooong mentioned this issue Nov 7, 2019
Merged
9 tasks
@csells csells changed the title Revise CupertinoColors and CupertinoTheme Revise CupertinoColors and CupertinoTheme for dynamic colors Jan 10, 2020
@csells csells added the c: new feature Nothing broken; request for a new capability label Jan 10, 2020
@xster
Copy link
Member

xster commented Apr 30, 2020

@LongCatIsLooong it looks like you're done here

@xster xster closed this as completed Apr 30, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LongCatIsLooong LongCatIsLooong

Labels
c: new feature Nothing broken; request for a new capability f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xster @csells @shihaohong @LongCatIsLooong