Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Detach from GL context before attaching #31390

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

blasten
Copy link

@blasten blasten commented Feb 11, 2022

When the rasterizer tasks run on a different thread, the GrContext is re-created.
This causes the texture to be in an uninitialized state.
This should not be an issue once platform views are always rendered as TextureLayers
since thread merging will be always disabled on Android.

Fixes flutter/flutter#98155

Emmanuel Garcia added 2 commits February 10, 2022 19:56
@blasten blasten force-pushed the fix_tx_attachToGLContext branch from 48f4b86 to b797079 Compare February 11, 2022 19:27
@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 11, 2022
@fluttergithubbot fluttergithubbot merged commit 81a87c8 into flutter:main Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 11, 2022
itsjustkevin pushed a commit to itsjustkevin/engine that referenced this pull request Feb 17, 2022
itsjustkevin added a commit that referenced this pull request Feb 18, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Fix crash in BackdropFilterLayer::Diff (#30460)

* Fix crash in BackdropFilterLayer::Diff

* Pass context transform to filterBounds instead of scaling the filter

* Disable building examples by default (#30946)

This should be paired with a recipe change to enable building the example on CI that I'll prepare shortly.

* Detach from GL context before attaching (#31390)

* 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml'

* remove ref to branch

* add junit dependency to gradle.build

Co-authored-by: Matej Knopp <matej.knopp@gmail.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Co-authored-by: Kevin Chisholm <kevinjchisholm@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] App crashes after upgrading to 2.10.x using webview + video_player plugin
3 participants