This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove the ios_tools Chromium-style dependency #30538
Merged
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggfly
force-pushed
the
remove_ios_tools_deps
branch
from
81c631b to
ee0934c
Compare
eggfly
changed the title
|
cc @jason-simmons @cbracken. This seems like a good idea to me and I couldn't find any references to the usage of this dependency anymore. |
eggfly
requested review from
jason-simmons,
dnfield,
chinmaygarde,
akbiggs and
cbracken
|
@jmagman should know |
|
IIRC I added this years ago before we moved to LUCI infra and our current XCode selection tooling. This also appears unused to me and can be deleted. |
cbracken
approved these changes
Jan 4, 2022
eggfly
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 6, 2022
* 9481a79 Roll Skia from 45f64bd52835 to 6bebf036a502 (2 revisions) (flutter/engine#30659) * fb4a86c Roll Fuchsia Mac SDK from RyUwCnr_M... to vpa6vKu7U... (flutter/engine#30661) * 154bd96 Roll Skia from 6bebf036a502 to 5726d457cf15 (1 revision) (flutter/engine#30665) * ba23c6c Roll Skia from 5726d457cf15 to 61d0fbbca795 (5 revisions) (flutter/engine#30673) * e749ba3 Impl and test (flutter/engine#30488) * a78103c Removed "UiThread" annotation from MethodChannel#Result. (flutter/engine#30671) * f8a398f Fix crash in BackdropFilterLayer::Diff (flutter/engine#30460) * a6a856f Only provide frame damage to rasterizer if partial repaint is enabled (flutter/engine#30461) * 3a667ab Roll Fuchsia Mac SDK from vpa6vKu7U... to Al-HXHXyQ... (flutter/engine#30677) * 830abeb [web] roll CanvasKit 0.32.0; fix frame order in animated images (flutter/engine#30680) * c726121 Add a new display_list_benchmarks test suite (flutter/engine#30678) * f181c4d [web] flip browser image codec flag to opt-out (flutter/engine#30681) * 436a346 Remove the ios_tools Chromium-style dependency (flutter/engine#30538) * 3f63998 [web] bring libraries.yaml/libraries.json up to date (flutter/engine#30467) * ab1e8f5 Roll Skia from 61d0fbbca795 to 4981c921c6d7 (1 revision) (flutter/engine#30684) * 8e4124b Roll Skia from 4981c921c6d7 to d7771857e9e2 (2 revisions) (flutter/engine#30685) * acb60b4 Roll Fuchsia Mac SDK from Al-HXHXyQ... to G04Sc3__F... (flutter/engine#30687) * 0176295 [Win32, Keyboard] TextInputPlugin is no longer a KeyboardHandlerBase (flutter/engine#30456) * bcb4b35 Roll Skia from d7771857e9e2 to ec2e8f11b97a (1 revision) (flutter/engine#30688) * e09f8d1 Roll Dart SDK from 1697706df708 to ab5047720a9e (5 revisions) (flutter/engine#30690) * d60c816 Roll Dart SDK from 1697706df708 to f59531cc2973 (10 revisions) (flutter/engine#30691) * 417042c GN targets for generating release artifacts (flutter/engine#30679) * 7f31015 Roll Skia from ec2e8f11b97a to 84d6cf9b5b76 (7 revisions) (flutter/engine#30693) * fed9e0b Roll Skia from 84d6cf9b5b76 to 88c5af7ecd72 (3 revisions) (flutter/engine#30695) * 36eafae [fuchsia][shader warmup] fix for fxbug.dev/90387 (flutter/engine#30482) * 0c036a7 Revert "Only provide frame damage to rasterizer if partial repaint is enabled (#30461)" (flutter/engine#30696) * 8498779 [fuchsia] Fix failing SDK roll. (flutter/engine#30675)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference this old issue: flutter/flutter#10510
Maybe xcode 8 / iOS SDK 10.3 is very old and
find_xcode.pyis also old? Not sure whether it is still used on internal repo:https://chromium-review.googlesource.com/c/chromium/tools/build/+/525074/6/scripts/slave/recipes/flutter/flutter.py#112
Can we do some clean up work?
Pre-launch Checklist
writing and running engine tests.
///).