Fix problem that using multi-engines, sometimes OpenGL would crash be… #17366

wqyfavor · 2020-03-27T07:54:51Z

…cause of invalid EAGLContext.

We are using multi-engines in our app. So there are chances that an iOS render target would be deallocated.

We found random crash and finally found that when ios_render_target_gl is being destructed.
The first line of this function "EAGLContext* context = EAGLContext.currentContext;". The context is actually equal to "context_.get()". So an invalid opengl context is set to current.

…cause of invalid EAGLContext.

googlebot · 2020-03-27T07:54:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-27T07:54:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

wqyfavor · 2020-03-27T08:01:54Z

@googlebot I signed it!

googlebot · 2020-03-27T08:01:57Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-27T08:01:57Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

chinmaygarde

ooh, thats subtle. Thanks for the fix. Can you clang-format this patch please? This is whats causing the presubmit failures. LGTM otherwise.

chinmaygarde · 2020-03-27T08:40:28Z

Thanks.

…crash be cause of invalid EAGLContext (flutter/engine#17366)

Fix problem that using multi-engines, sometimes OpenGL would crash be…

f8178af

…cause of invalid EAGLContext.

auto-assign bot requested a review from gw280 March 27, 2020 07:54

googlebot added the cla: no label Mar 27, 2020

googlebot added cla: yes and removed cla: no labels Mar 27, 2020

chinmaygarde approved these changes Mar 27, 2020

View reviewed changes

Fix for clang-format complaint.

b680f30

chinmaygarde added the waiting for tree to go green label Mar 27, 2020

chinmaygarde merged commit 82c7ab0 into flutter:master Mar 27, 2020

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2020

82c7ab0 Fix problem that using multi-engines, sometimes OpenGL would …

91cd91c

…crash be cause of invalid EAGLContext (flutter/engine#17366)

engine-flutter-autoroll mentioned this pull request Mar 27, 2020

Roll engine 67e66f7c8118..020d7c5c80ee (3 commits) flutter/flutter#53424

Merged

jmagman mentioned this pull request Jun 5, 2020

flutterViewController Multiple Entry and pop, [flutterViewController dealloc] crashed flutter/flutter#37225

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix problem that using multi-engines, sometimes OpenGL would crash be… #17366

Fix problem that using multi-engines, sometimes OpenGL would crash be… #17366

wqyfavor commented Mar 27, 2020

googlebot commented Mar 27, 2020

googlebot commented Mar 27, 2020

wqyfavor commented Mar 27, 2020

googlebot commented Mar 27, 2020

googlebot commented Mar 27, 2020

chinmaygarde left a comment

chinmaygarde commented Mar 27, 2020

Fix problem that using multi-engines, sometimes OpenGL would crash be… #17366

Fix problem that using multi-engines, sometimes OpenGL would crash be… #17366

Conversation

wqyfavor commented Mar 27, 2020

googlebot commented Mar 27, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Mar 27, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

wqyfavor commented Mar 27, 2020

googlebot commented Mar 27, 2020

googlebot commented Mar 27, 2020

chinmaygarde left a comment

Choose a reason for hiding this comment

chinmaygarde commented Mar 27, 2020