Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BackgroundMode public. (#45747) #14673

Merged
merged 1 commit into from Jan 9, 2020
Merged

Make BackgroundMode public. (#45747) #14673

merged 1 commit into from Jan 9, 2020

Conversation

matthew-carroll
Copy link
Contributor

Make BackgroundMode public. (#45747)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@matthew-carroll matthew-carroll mentioned this pull request Dec 22, 2019
Closed
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@xster
Copy link
Member

xster commented Dec 30, 2019

LGTM. Thanks

mklim
mklim approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster xster merged commit 4513205 into flutter:master Jan 9, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
83c283a 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
b8ad042 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
5cd6754 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
d5f3323 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
b62b32c 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
47b6726 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
5829c02 
…4673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
f5c3857 
…4673)
@GaryQian GaryQian mentioned this pull request Jan 10, 2020
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2020
@engine-flutter-autoroll
4513205 Make BackgroundMode public. (flutter#45747) (flutter/engine#1…
8f57c52 
…4673)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@matthew-carroll @NoamDev
Make BackgroundMode public. (flutter#45747) (flutter#14673)
a57823c
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "Make BackgroundMode public. (flutter#45747) (flutter#14673)"
b92bac7 
This reverts commit a57823c.
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@matthew-carroll @filmil
Make BackgroundMode public. (flutter#45747) (flutter#14673)
872530c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mklim mklim mklim approved these changes

@xster xster Awaiting requested review from xster

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@matthew-carroll @googlebot @xster @mklim