Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][A11y] AccessibilityInfo.announceForAccessibility #24746

Closed
wants to merge 3 commits into from
Closed

[Android][A11y] AccessibilityInfo.announceForAccessibility #24746

wants to merge 3 commits into from

Conversation

adkenyon
Copy link
Contributor

@adkenyon adkenyon commented May 7, 2019

Summary

AccessibilityInfo.announceForAccessibility is currently only available on iOS. I've added the Android specific implementation, updated RNTester, and the documentation.

Changelog

[Android] [Added] - Added AccessibilityInfo.announceForAccessibility for Android
[General] [Added] - RNTester example for AccessibilityInfo.announceForAccessibility

Test Plan

Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
RNTester/js/AccessibilityExample.js Outdated Show resolved Hide resolved
@react-native-bot react-native-bot added API: AccessibilityInfo Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels May 7, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! Thank you so much for making sure Android and iOS are consistent and for adding accessibility features :)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @adkenyon in 09f17a4.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 8, 2019
@estevaolucas
Copy link

really awesome 💪 👏 @adkenyon.

@adkenyon adkenyon deleted the android-accessibility-info-announce-for-accessibility branch May 8, 2019 17:14
AKB48 pushed a commit to UnPourTous/react-native that referenced this pull request Apr 21, 2020
AKB48 pushed a commit to UnPourTous/react-native that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: AccessibilityInfo CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants