React Native v0.43 ViewPagerAndroid work not well when detached then attach #13463

liuzhibopp · 2017-04-12T08:43:23Z

Description

Integration With Existing Apps
on 0.42 ViewPagerAndroid work well when detached then attach , after upgrading to React Native v0.43 when i slide one page to other page ，no smooth scroll and stop in middle ,i compared two version of react native.

Reproduction Steps and Sample Code

0.42 when i slide viewpager following codes will work and 0.43 there no updateLayout for ViewPagerAndroid :
java.lang.Thread.State: RUNNABLE at android.support.v4.view.ViewPager.onLayout(ViewPager.java:1705) at android.view.View.layout(View.java:16980) at android.view.ViewGroup.layout(ViewGroup.java:5550) at com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout(NativeViewHierarchyManager.java:199) at com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout(NativeViewHierarchyManager.java:184) at com.facebook.react.uimanager.UIViewOperationQueue$UpdateLayoutOperation.execute(UIViewOperationQueue.java:124) at com.facebook.react.uimanager.UIViewOperationQueue$2.run(UIViewOperationQueue.java:784) at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:831) - locked <0x1e9d> (a java.lang.Object) at com.facebook.react.uimanager.UIViewOperationQueue.access$1500(UIViewOperationQueue.java:45) at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:870) at com.facebook.react.uimanager.GuardedChoreographerFrameCallback.doFrame(GuardedChoreographerFrameCallback.java:32) at com.facebook.react.uimanager.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:131) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:925) at android.view.Choreographer.doCallbacks(Choreographer.java:718) at android.view.Choreographer.doFrame(Choreographer.java:650) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:913) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:5660) at java.lang.reflect.Method.invoke(Method.java:-1) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Solution

I don‘t know whether there is a relationship with the following changes ：

Only call onLayout when layout has actually changed (15429e3)

how to fix ?
thanks in advance!

The text was updated successfully, but these errors were encountered:

henrytao-me · 2017-04-23T06:48:18Z

Hi @liuzhibopp ,

I ended up writing this custom component to wrap ViewPagerAndroid. It works on my side. Please check.

ViewPagerAndroidContainer

import React, { PureComponent } from 'react'
import { View } from 'react-native'

class ViewPagerAndroidContainer extends PureComponent {

  state = {
    width: 0,
    height: 0
  }

  render() {
    return (
      <View style={[this.props.style]} onLayout={this._onLayoutChange}>
        <View style={{ width: this.state.width, height: this.state.height }}>{this.props.children}</View>
      </View>
    )
  }

  _onLayoutChange = (e) => {
    const { width, height } = e.nativeEvent.layout
    this.setState({ width: width, height: height })
  }
}

export default ViewPagerAndroidContainer

Usage

<ViewPagerAndroidContainer style={{ flex: 1 }}>
  <ViewPagerAndroid ref='viewPager' style={{ flex: 1 }} initialPage={selectedIndex} onPageSelected={this._onPageSelected}>
    ...
  </ViewPagerAndroid>
</ViewPagerAndroidContainer>

liuzhibopp · 2017-04-24T03:18:39Z

hi @henrytao-me,
Sorry for so long to reply to you，I test just now and it does not work for me. I try to extended ViewPager modifies the mFirstlayout property by reflection，it works for me.
I hope to have a better way for the issue，Thanks for your answer.

satya164 · 2017-05-10T04:46:53Z

This issue seems to provide some insight to the bug expo/ex-navigation#415 (comment)

sibelius · 2017-05-11T14:40:46Z

I can confirm this

bood · 2017-05-22T03:38:37Z

Met similar issue when adding pages to ViewPagerAndroid dynamically
Problem does seems to point to 15429e3, not sure if the commit is still necessary after Yoga fixes @astreet ?
layout of ReactViewPager is no longer invoked after the change in this case. However, newly added ReactViewGroup children of ReactViewPager requires the layout to be called to be properly layout-ed.

A temp working fix is to by-pass the optimization for ReactViewPager in dispatchUpdates (by comparing mViewClassName). You can try it out too.

I'll open a separate issue if needed.

astreet · 2017-05-22T15:37:29Z

Yeah, we're not handling layout correctly here: the view should be given the ability to lay itself out (and its children) if it so requests. However, we're able to bypass a lot of extra work since the majority of views don't use this ability.

My first thought it to try to solve this by giving the view manager the ability to request the UIManager to layout the corresponding view in the next dispatchUpdates (e.g. exposing a new command on UIManager)

Jackoder · 2017-06-05T03:26:00Z

This is my temp working fix:

Hack ReactViewPager to modify mFirstLayout member

import android.support.v4.view.ViewPager;

import com.facebook.react.bridge.ReactContext;
import com.facebook.react.views.viewpager.ReactViewPager;

import java.lang.reflect.Field;

public class FixReactViewPager extends ReactViewPager {

    boolean hasLayout;

    public FixReactViewPager(ReactContext reactContext) {
        super(reactContext);
    }

    @Override
    protected void onLayout(boolean changed, int l, int t, int r, int b) {
        super.onLayout(changed, l, t, r, b);
        hasLayout = true;
    }

    @Override
    protected void onAttachedToWindow() {
        super.onAttachedToWindow();
        if (hasLayout) {
            Class<ViewPager> clazz = ViewPager.class;
            try {
                Field field = clazz.getDeclaredField("mFirstLayout");
                field.setAccessible(true);
                field.set(this, false);
                field.setAccessible(false);
            } catch (NoSuchFieldException e) {
                e.printStackTrace();
            } catch (IllegalAccessException e) {
                e.printStackTrace();
            }
        }
    }
}

Inject Manager with the same name AndroidViewPager

import com.facebook.react.uimanager.ThemedReactContext;
import com.facebook.react.views.viewpager.ReactViewPager;
import com.facebook.react.views.viewpager.ReactViewPagerManager;

public class FixReactViewPagerManager extends ReactViewPagerManager {

    public String getName() {
        return "AndroidViewPager";
    }

    @Override
    protected ReactViewPager createViewInstance(ThemedReactContext reactContext) {
        return new FixReactViewPager(reactContext);
    }
}

itinance · 2017-06-25T11:06:18Z

The workaround from @henrytao-me didn't work for us, but we could fix the issue on RN 0.45.1 with the following workaround: for those cases, when we want to replace the already existing ViewPager with new children, we enforce a re-render while passing a id-property:

const id= ...something to create an id that reflacts the state of the pages and will change every time when pages will change

        <IndicatorViewPager
          id={id}
          ref={(c) => this.setViewPagerRef(c, id)}
          style={{width: DEVICE_WIDTH, height: slideHeight}}
          pagerStyle={{width: DEVICE_WIDTH, height: slideHeight}}
          initialPage={0}
          indicator={this.renderDotIndicator(slideCount)}
          onPageSelected={this.handlePageSelected}
          >
          {slides}
        </IndicatorViewPager>

cbjs · 2017-07-19T09:26:54Z

+1

@astreet

In some scenarios, the view pager gets stuck in and it's not possible to update the pages. I did some digging and found the following. In native `ViewPager`, the `onAttachedToWindow` method gets called on start, which sets a variable called `mFirstLayout` to `true`. Then `onLayout` method gets called, which sets `mFirstLayout` to `false`, since first layout has occurred now. But then `onAttachedToWindow` method gets called again for some reason which resets `mFirstLayout` to `true`. This makes the `ViewPager` stuck since `mFirstLayout` variable never updates again, and to be able to animate the pager, the native component expects it to be `false`. I also discovered that @rauliyohmc arrived at the same conclusions here, which describes it in more detail - expo/ex-navigation#415 (comment) This PR is a hacky attempt to prevent `onAttachedToWindow` being called again after first layout since I am unsure about the correct fix. Fixes #13463 cc @astreet

INCHMAN1900 · 2017-09-17T12:05:52Z

@henrytao-me you answer works for me, but there is more work to do.
If you nest viewPagerAndroid in a TabNavigator, you need to set swipeEnabled and animationEnabled to true, at least one of them. If they're both false , then viewPagerAndroid will work very slowly, and get stuck between the pages.

stale · 2017-11-16T12:27:08Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

liuzhibopp · 2017-11-17T08:16:13Z

New work not using RN for a long time, so forget to care this issue，I've already put forward a method that modifies the # mFirstlayout property by reflection to slove the issue ，like @Jackoder ，I hope this problem has been solved in an elegant way.

Noitidart · 2017-11-30T23:54:02Z

I copied pasted the docs example of ViewPagerAndroid but it doesnt work for me. It doesnt render its children it seems, its mind boggling:

            <View style={styles.main}>
                <ViewPagerAndroid style={styles.viewPager} initialPage={0}>
                    <View style={styles.pageStyle}>
                        <Text>First page</Text>
                    </View>
                    <View style={styles.pageStyle}>
                        <Text>Second page</Text>
                    </View>
                </ViewPagerAndroid>
            </View>

    main: {
        flex: 1
    },
    viewPager: {
        height: 100,
        backgroundColor: 'green'
    },
    pageStyle: {
        alignItems: 'center',
        padding: 20,
        width: 100,
        height: 100,
        backgroundColor: 'green',
        flex: 1
    }

Anyone have any ideas? It just shows a 100 height green box.

Noitidart · 2017-12-01T02:44:55Z

Wow @henrytao-me thanks for ViewPagerAndroidContainer it makes it work. So weird. However peekEnabled is not working, do you know how to get that to work?

danilobuerger · 2017-12-24T16:20:16Z

There is a fix here: #14867
A shame that nobody seems to care to get this merged.

satya164 · 2017-12-24T18:02:22Z

@danilobuerger

You can see that I asked for a test plan, but the author didn't respond. I can't merge things without having a way to test it if it actually works and doesn't break anything. I don't see how nobody cares to get this merged.

danilobuerger · 2017-12-24T18:05:26Z

@satya164 So if the original author disappeared, we just wait for a test plan forever?

satya164 · 2017-12-24T23:06:05Z

Someone else can send a PR. What do you want me to do? Merge without testing?

danilobuerger · 2017-12-28T08:18:06Z

@satya164 I didn't ask you to do anything. But since you are responding, and since you submitted a similar PR, wouldn't it make sense for you to write a test? If it's just about having a project where you can see that the PR actually works, I can supply you with one.

danilobuerger · 2017-12-28T09:43:41Z

For anybody else running into this issue: I have created a fork here: https://github.com/feastr/react-native and will be maintaining this (and porting to new versions whenever released) until the issue is fixed upstream. To use, just replace the react-native dependency in your package.json with:

"dependencies": {
  "react-native": "feastr/react-native#0.51-stable"
}

satya164 · 2017-12-28T15:03:37Z

I don't need a written test, just a way to test if the change actually works. If you have one, please send a PR with a minimal example where I can check if it's actually fixed.

I could write a test, but I don't have a lot of free time. And since someone sent a PR, they probably already have a test plan.

danilobuerger · 2017-12-28T17:04:21Z

@satya164 I will use the already existing PR #14867 and comment a test plan there.

satya164 · 2017-12-28T17:07:11Z

@danilobuerger sounds good

bood · 2018-01-04T02:42:01Z

@satya164 @danilobuerger But the fix does not seems to solve the problem of dynamic adding a page to ViewPager, code sample below:

import React, { Component } from 'react';
import { View, Text, ViewPagerAndroid } from 'react-native';

export default class DebugViewPager extends Component {
  constructor(props) {
    super(props);
    this.state = {
      npage: 2,
    };
  }
  render() {
    let pages = []
    for (var i = 1; i <= this.state.npage; i++) {
      let bg = (i % 2 == 0) ? 'blue' : 'yellow';
      pages.push(
        <View style={[styles.pageStyle], [{backgroundColor: bg}]} key={i}>
          <Text>Page {i}</Text>
        </View>
      )
    }
    viewPager = (<ViewPagerAndroid
             style={styles.viewPager}
             initialPage={0}>
      {pages}
    </ViewPagerAndroid>);
    return (
      <View style={styles.viewPager}>
        {viewPager}
        <Text style={styles.add} onPress={()=>{
            this.setState({npage: this.state.npage + 1})
        }}>
          Add Page
        </Text>
      </View>
    )
  }
}

var styles = {
  viewPager: {
    flex: 1,
    backgroundColor: 'white',
  },
  pageStyle: {
    alignItems: 'center',
    padding: 20,
  },
  add: {
    height: 100,
    width: 100,
    backgroundColor: 'red'
  }
}

satya164 · 2018-01-04T02:59:14Z

Thanks for the comment. Can you copy/paste the comment on the linked PR too?

bood · 2018-01-04T03:02:19Z

Done

@henrytao-me

It uses ViewPagerAndroidContainer workaround proposed by @henrytao-me You can read more about it here: * RN bug report facebook/react-native#13463 * PR for fixing it facebook/react-native#1486 * Other projects are affectd too react-navigation/react-navigation#1442

hramos · 2018-05-17T17:55:49Z

#14867 merged.

Summary: This sync includes the following changes: - **[ade5e6928](facebook/react@ade5e6928)**: Manually update schedule dep in react-native-renderer (#13609) //<Brian Vaughn>// - **[f260b14a8](facebook/react@f260b14a8)**: Fix host bailout for the persistent mode (#13611) //<Dan Abramov>// - **[4a40d7624](facebook/react@4a40d7624)**: Fix a regression related to isReactComponent prototype check (#13608) //<Dan Abramov>// - **[03ab1efeb](facebook/react@03ab1efeb)**: Improve DX when combining react-dom/profiling and schedule/tracking (#13605) //<Brian Vaughn>// - **[144328fe8](facebook/react@144328fe8)**: Enable no-use-before-define rule (#13606) //<Dan Abramov>// - **[8a8d973d3](facebook/react@8a8d973d3)**: Use clearer wording //<Dan>// - **[7d1169b2d](facebook/react@7d1169b2d)**: Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub (#13598) //<Brandon Dail>// - **[8d1038fc6](facebook/react@8d1038fc6)**: Break up ReactDOMServerIntegrationForm-test (#13600) //<Nathan Hunzaker>// - **[b87aabdfe](facebook/react@b87aabdfe)**: Drop the year from Facebook copyright headers and the LICENSE file. (#13593) //<Héctor Ramos>// - **[e417e0bf7](facebook/react@e417e0bf7)**: Update ReactNativeViewConfigRegistry Flow Types (#13579) //<Timothy Yung>// - **[71c0e05ba](facebook/react@71c0e05ba)**: Update bundle sizes for 16.5.0 release //<Brian Vaughn>// - **[6255cc394](facebook/react@6255cc394)**: Updating package versions for release 16.5.0 //<Brian Vaughn>// - **[28cb37978](facebook/react@28cb37978)**: Added a test for Profiler onRender that throws (#13575) //<Brian Vaughn>// - **[8963118b3](facebook/react@8963118b3)**: Update react-dom README //<Dan Abramov>// - **[b47a28cb9](facebook/react@b47a28cb9)**: Tweak react-dom README //<Dan Abramov>// - **[f765f0225](facebook/react@f765f0225)**: When a root expires, flush all expired work in a single batch (#13503) //<Andrew Clark>// - **[550dd1d2e](facebook/react@550dd1d2e)**: Call Profiler onRender after mutations (#13572) //<Brian Vaughn>// - **[34348a45b](facebook/react@34348a45b)**: Add enableSuspenseServerRenderer feature flag (#13573) //<Alex Taylor>// - **[4e744be6e](facebook/react@4e744be6e)**: Added react-dom/profiling entry point to NPM package (#13570) //<Brian Vaughn>// - **[bb627228e](facebook/react@bb627228e)**: test: add test for fragement props (#13565) //<laoxiong>// - **[9a110ebd8](facebook/react@9a110ebd8)**: Cleaned up 'schedule' API wrt interactions and subscriber ref: (#13561) //<Brian Vaughn>// - **[fb88fd9d8](facebook/react@fb88fd9d8)**: Fixed schedule/tracking require for www sync script (#13556) //<Brian Vaughn>// - **[955393cab](facebook/react@955393cab)**: refactor: remove emove type judgment when defining warning props (#13553) //<laoxiong>// - **[ff9399602](facebook/react@ff9399602)**: Fix import of ReactDOM in server env //<Dan Abramov>// - **[281bd64c0](facebook/react@281bd64c0)**: Fix test file name //<Dan Abramov>// - **[d6b59e3d2](facebook/react@d6b59e3d2)**: Check document.documentMode once //<Dan Abramov>// - **[52633c84e](facebook/react@52633c84e)**: Try/finally //<Dan Abramov>// - **[2d4705e75](facebook/react@2d4705e75)**: Make IE 11 not complain about non-crucial style attribute hydration mismatch (#13534) //<Michał Gołębiowski-Owczarek>// - **[25d48a728](facebook/react@25d48a728)**: Add gridArea to unitless CSS properties (#13550) //<Michał Gołębiowski-Owczarek>// - **[877f8bc6b](facebook/react@877f8bc6b)**: Renamed schedule UMD forwarding methods to stay in-sync with SECRET_INTERNALS change (#13549) //<Brian Vaughn>// - **[0a96f9057](facebook/react@0a96f9057)**: Revert "Extract common logic" (#13547) //<Dan Abramov>// - **[17a57adde](facebook/react@17a57adde)**: Fix test //<Dan Abramov>// - **[605da8b42](facebook/react@605da8b42)**: Extract common logic (#13535) //<Heaven>// - **[69f9f4127](facebook/react@69f9f4127)**: Document event bubble order (#13546) //<Philipp>// - **[c1ba7b8cf](facebook/react@c1ba7b8cf)**: Remove www scheduler fork (#13545) //<Dan Abramov>// - **[b473d5f86](facebook/react@b473d5f86)**: Secret exports: Scheduler => Schedule (#13544) //<Dan Abramov>// - **[6312efc34](facebook/react@6312efc34)**: Tweak README and description //<Dan Abramov>// - **[b92f947af](facebook/react@b92f947af)**: Rename "react-scheduler" package to "schedule" (#13543) //<Brian Vaughn>// - **[3c1dcd349](facebook/react@3c1dcd349)**: Expose less internals for TestUtils (#13539) //<Dan Abramov>// - **[0b74e95d7](facebook/react@0b74e95d7)**: Ignore noscript content on the client (#13537) //<Fredrik Höglund>// - **[8a1e3962a](facebook/react@8a1e3962a)**: Remove negative lookbehind from Rollup plugin that broke Node <= v8.9 (#13538) //<Brian Vaughn>// - **[9604d26ae](facebook/react@9604d26ae)**: Rename ReactDOMFiber* to ReactDOM* (#13540) //<Dan Abramov>// - **[28b928902](facebook/react@28b928902)**: Tidied up scheduling UMD API forwarding test (#13533) //<Brian Vaughn>// - **[bf8aa6092](facebook/react@bf8aa6092)**: Added Jest test to verify UMD API-forwarding for scheduling package (#13532) //<Brian Vaughn>// - **[0040efc8d](facebook/react@0040efc8d)**: Fix a typo (#13531) //<Heaven>// - **[46950a3df](facebook/react@46950a3df)**: Interaction tracking follow up (#13509) //<Brian Vaughn>// - **[0452c9bba](facebook/react@0452c9bba)**: Add a regression test for #4618 //<Dan Abramov>// - **[c21bab694](facebook/react@c21bab694)**: Add SSR regression test for #6119 //<Dan Abramov>// - **[0d3fc9de1](facebook/react@0d3fc9de1)**: Add regression test for #6119 //<Dan Abramov>// - **[0f050ad7c](facebook/react@0f050ad7c)**: Make regression test better //<Dan Abramov>// - **[f94342323](facebook/react@f94342323)**: Add a more precise regression test for #6219 //<Dan Abramov>// - **[a3e4d0008](facebook/react@a3e4d0008)**: Fixed typo (#13519) //<Ivan>// - **[b3d8c5376](facebook/react@b3d8c5376)**: [RN] Remove isMounted() false positive warning (#13511) //<Dan Abramov>// - **[d2123d656](facebook/react@d2123d656)**: Sync React Native Flow Changes (#13513) //<Timothy Yung>// - **[1c0ba70b4](facebook/react@1c0ba70b4)**: Fix test to use AsyncMode //<Dan>// - **[6e4f7c788](facebook/react@6e4f7c788)**: Profiler integration with interaction-tracking package (#13253) //<Brian Vaughn>// - **[2967ebdbe](facebook/react@2967ebdbe)**: Remove buggy unstable_deferredUpdates() (#13488) //<Dan Abramov>// - **[1664b08f0](facebook/react@1664b08f0)**: added flow types to setInnerHTML (#13495) //<Bryan M>// - **[672e859d3](facebook/react@672e859d3)**: Add warning to prevent setting this.state to this.props referentially (#11658) //<Veekas Shrivastava>// - **[29287f088](facebook/react@29287f088)**: Rename lowestPendingInteractiveExpirationTime (#13484) //<Heaven>// - **[d400d6d5e](facebook/react@d400d6d5e)**: Replace magic number 1 with ELEMENT_NODE (#13479) //<Heaven>// - **[340bfd939](facebook/react@340bfd939)**: Rename ReactTypeOfWork to ReactWorkTags, ReactTypeOfSideEffect to ReactSideEffectTags (#13476) //<Sophie Alpert>// - **[5cefd9b1e](facebook/react@5cefd9b1e)**: Stringify <option> children (#13465) //<Dan Abramov>// - **[3661616c2](facebook/react@3661616c2)**: Improve test harness of submit events (#13463) //<Philipp Spieß>// - **[a1be17140](facebook/react@a1be17140)**: Revert "Rely on bubbling for submit and reset events (#13358)" (#13462) //<Dan Abramov>// - **[90c92c700](facebook/react@90c92c700)**: Fix warning message //<Dan Abramov>// - **[5cb0f2bf5](facebook/react@5cb0f2bf5)**: Change www error shim API (#13454) //<Dan Abramov>// - **[e106b8c44](facebook/react@e106b8c44)**: Warn about unsafe toWarnDev() nesting in tests (#12457) //<Brian Vaughn>// - **[026aa9c97](facebook/react@026aa9c97)**: Bumped version to 16.4.3-alpha.0 (#13448) //<Brian Vaughn>// - **[d670bdc6b](facebook/react@d670bdc6b)**: Warn about ReactDOM.createPortal usage within ReactTestRenderer (#12895) //<Brian Vaughn>// - **[bf1abf478](facebook/react@bf1abf478)**: Fix React.lazy(forwardRef) (#13446) //<Dan Abramov>// - **[e8571c798](facebook/react@e8571c798)**: Tweak ReactTypeOfWork order (#13444) //<Dan Abramov>// - **[973496b40](facebook/react@973496b40)**: Fix component name for React.lazy (#13443) //<Dan Abramov>// - **[0beb2ee76](facebook/react@0beb2ee76)**: Fix incorrect legacy context for factory components (#13441) //<Dan Abramov>// - **[004cb21bb](facebook/react@004cb21bb)**: Short circuit the logic for exporting a module (#13392) //<Joseph>// - **[f7a538c91](facebook/react@f7a538c91)**: Remove getTextContentAccessor (#13434) //<Brandon Dail>// - **[d1c42d2f1](facebook/react@d1c42d2f1)**: Remove addEventListener check in isEventSupported (#13435) //<Brandon Dail>// - **[a869f992a](facebook/react@a869f992a)**: Remove helper object from FallbackCompositionState (#13430) //<Brandon Dail>// - **[0cd8d470d](facebook/react@0cd8d470d)**: Do not toLowerCase lists of lowercase words (#13428) //<Nathan Hunzaker>// - **[b3a4cfea5](facebook/react@b3a4cfea5)**: Trap click events for portal root (#11927) //<Brandon Dail>// - **[0da5102cf](facebook/react@0da5102cf)**: Add interaction-tracking/subscriptions (#13426) //<Brian Vaughn>// - **[4b32f525e](facebook/react@4b32f525e)**: Refactor away some namespace imports (#13427) //<Dan Abramov>// - **[d2f5c3fbc](facebook/react@d2f5c3fbc)**: Don't diff memoized host components in completion phase (#13423) //<Dan Abramov>// - **[5e0f073d5](facebook/react@5e0f073d5)**: interaction-tracking package (#13234) //<Brian Vaughn>// - **[d14e443d6](facebook/react@d14e443d6)**: Resume onSelect tracking after dragend (#13422) //<Dan Abramov>// - **[d5edc1f51](facebook/react@d5edc1f51)**: Remove unused ReactCall & ReactReturn types (#13419) //<Esteban>// - **[4fa20b53b](facebook/react@4fa20b53b)**: Don't pass instanceHandle to clones (#13125) //<Sebastian Markbåge>// - **[fe959eea7](facebook/react@fe959eea7)**: React.lazy (#13398) //<Andrew Clark>// - **[2b3082800](facebook/react@2b3082800)**: Fix wrong Flow return type //<Andrew Clark>// - **[5031ebf6b](facebook/react@5031ebf6b)**: Accept promise as element type (#13397) //<Andrew Clark>// - **[77b7a660b](facebook/react@77b7a660b)**: fix: do not reconcile children that are iterable functions (#13416) //<Rauno Freiberg>// - **[cb7745c6c](facebook/react@cb7745c6c)**: remove unused state initialValue from ReactDOMFiberSelect (#13412) //<Kartik Lad>// - **[9832a1b6d](facebook/react@9832a1b6d)**: Avoid setting empty value on reset & submit inputs (#12780) //<Ellis Clayton>// - **[8862172fa](facebook/react@8862172fa)**: Provide a better error message (#12421) //<Aaron Brager>// - **[581682917](facebook/react@581682917)**: De-duplicate commitUpdateQueue effect commit (#13403) //<Ruud Burger>// - **[1bc975d07](facebook/react@1bc975d07)**: Don't stop context traversal at matching consumers (#13391) //<Andrew Clark>// - **[83e446e1d](facebook/react@83e446e1d)**: Refactor ReactErrorUtils (#13406) //<Dan Abramov>// - **[13fa96a54](facebook/react@13fa96a54)**: Improve bad ref invariant (#13408) //<Dan Abramov>// - **[b2adcfba3](facebook/react@b2adcfba3)**: Don't suppress jsdom error reporting in our tests (#13401) //<Dan Abramov>// - **[69e2a0d73](facebook/react@69e2a0d73)**: Ability to access window.event in development (#11687) (#11696) //<Conrad Irwin>// - **[ade4dd3f6](facebook/react@ade4dd3f6)**: Fix typo in a comment (#13373) //<davidblnc>// - **[2c59076d2](facebook/react@2c59076d2)**: Warn when "false" or "true" is the value of a boolean DOM prop (#13372) //<Moti Zilberman>// - **[de5102c4c](facebook/react@de5102c4c)**: Ignore symbols and functions in select tag (#13389) //<Rauno Freiberg>// - **[d04d03e47](facebook/react@d04d03e47)**: Fix passing symbols and functions to textarea (#13362) //<Rauno Freiberg>// - **[5550ed4a8](facebook/react@5550ed4a8)**: Ensure arguments are coerced to strings in warnings (#13385) //<Nathan Hunzaker>// - **[3938ccc88](facebook/react@3938ccc88)**: Allow the user to opt out of seeing "The above error..." addendum (#13384) //<Dan Abramov>// - **[47e217a77](facebook/react@47e217a77)**: Provide component reference in ReactDOMFiberTextarea warnings (#13361) //<Rauno Freiberg>// - **[a0190f828](facebook/react@a0190f828)**: Rename SafeValue to ToStringValue (#13376) //<Philipp Spieß>// - **[33602d435](facebook/react@33602d435)**: Improve soundness of ReactDOMFiberInput typings (#13367) //<Philipp Spieß>// - **[ae855cec2](facebook/react@ae855cec2)**: Support tangentialPressure and twist fields of pointer events (#13374) //<Moti Zilberman>// - **[725e499cf](facebook/react@725e499cf)**: Rely on bubbling for submit and reset events (#13358) //<Philipp Spieß>// - **[e07a3cd28](facebook/react@e07a3cd28)**: fix typo on inline comment (#13364) //<Alex Rohleder>// - **[e0204084a](facebook/react@e0204084a)**: Fix typos detected by github.com/client9/misspell (#13349) //<Kazuhiro Sera>// - **[be4533af7](facebook/react@be4533af7)**: Fix hydration of non-string dangerousSetInnerHTML.__html (#13353) //<Dan Abramov>// - **[0072b5998](facebook/react@0072b5998)**: Improve scry() error message for bad first argument (#13351) //<Dan Abramov>// - **[d59b993a7](facebook/react@d59b993a7)**: Make nicer stacks DEV-only //<Dan>// - **[54d86eb82](facebook/react@54d86eb82)**: Improve display of filenames in component stack (#12059) //<Billy Janitsch>// - **[067cc24f5](facebook/react@067cc24f5)**: Profiler actualDuration bugfix (#13313) //<Brian Vaughn>// - **[3cfab14b9](facebook/react@3cfab14b9)**: Treat focusable as enumerated boolean SVG attribute (#13339) //<Dan Abramov>// - **[3b3b7fcbb](facebook/react@3b3b7fcbb)**: Don't search beyond Sync roots for highest priority work (#13335) //<Dan Abramov>// - **[08e32263f](facebook/react@08e32263f)**: Fix Prettier "No parser" warning while building (#13323) //<Bartosz Kaszubowski>// - **[ac7238856](facebook/react@ac7238856)**: Add support for auxclick event (#11571) //<Jason Quense>// - **[75491a8f4](facebook/react@75491a8f4)**: Add a regression test for #12200 (#12242) //<Gareth Small>// - **[2d0356a52](facebook/react@2d0356a52)**: Make sure that `select` has `multiple` attribute set to appropriate state before appending options (#13270) //<Dmytro Zasyadko>// - **[b179bae0a](facebook/react@b179bae0a)**: Enhance get derived state from props state warning - #12670 (#13317) //<Felix Wu>// - **[15a8f0318](facebook/react@15a8f0318)**: Fix ambiguity in doc comment for isValidElement (#12826) //<Alexey>// - **[5cff21207](facebook/react@5cff21207)**: add flowtype to function signature (#13285) //<ryota-murakami>// - **[b565f4953](facebook/react@b565f4953)**: Minimally support iframes (nested browsing contexts) in selection event handling (#12037) //<Andrew Patton>// - **[1609cf343](facebook/react@1609cf343)**: Warn about rendering Generators (#13312) //<Dan Abramov>// - **[46d5afc54](facebook/react@46d5afc54)**: Replace console.error() with a throw in setTimeout() as last resort exception logging (#13310) //<Dan Abramov>// - **[b3b80a483](facebook/react@b3b80a483)**: Inject react-art renderer into react-devtools (#13173) //<Yunchan Cho>// - **[5e8beec84](facebook/react@5e8beec84)**: Add a regression test for #11602 //<Dan Abramov>// - **[470377bbd](facebook/react@470377bbd)**: Remove extraneous condition //<Dan Abramov>// - **[6db080154](facebook/react@6db080154)**: Remove irrelevant suggestion of a legacy method from a warning (#13169) //<Ideveloper>// - **[f60a7f722](facebook/react@f60a7f722)**: Fix SSR crash on a hasOwnProperty attribute (#13303) //<Dan Abramov>// - **[ff41519ec](facebook/react@ff41519ec)**: Sanitize unknown attribute names for SSR (#13302) //<Dan Abramov>// - **[c44c2a216](facebook/react@c44c2a216)**: More helpful message when passing an element to createElement() (#13131) //<Dylan Cutler>// - **[28cd494bd](facebook/react@28cd494bd)**: Refactor validateDOMNesting a bit (#13300) //<Dan Abramov>// - **[b381f4141](facebook/react@b381f4141)**: Allow Electrons <webview> tag (#13301) //<Philipp Spieß>// - **[0182a7463](facebook/react@0182a7463)**: Fix a crash when using dynamic children in <option> tag (#13261) //<Konstantin Yakushin>// - **[2a2ef7e0f](facebook/react@2a2ef7e0f)**: Remove unnecessary branching from updateContextProvider (#13282) //<Andrew Clark>// - **[840cb1a26](facebook/react@840cb1a26)**: Add an invariant to createRoot() to validate containers (#13279) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions bc1ea9c...ade5e69 Reviewed By: bvaughn Differential Revision: D9561644 fbshipit-source-id: 3be120d7450f310af458897d54993a6c086cff2f

Summary: This sync includes the following changes: - **[ade5e6928](facebook/react@ade5e6928)**: Manually update schedule dep in react-native-renderer (facebook#13609) //<Brian Vaughn>// - **[f260b14a8](facebook/react@f260b14a8)**: Fix host bailout for the persistent mode (facebook#13611) //<Dan Abramov>// - **[4a40d7624](facebook/react@4a40d7624)**: Fix a regression related to isReactComponent prototype check (facebook#13608) //<Dan Abramov>// - **[03ab1efeb](facebook/react@03ab1efeb)**: Improve DX when combining react-dom/profiling and schedule/tracking (facebook#13605) //<Brian Vaughn>// - **[144328fe8](facebook/react@144328fe8)**: Enable no-use-before-define rule (facebook#13606) //<Dan Abramov>// - **[8a8d973d3](facebook/react@8a8d973d3)**: Use clearer wording //<Dan>// - **[7d1169b2d](facebook/react@7d1169b2d)**: Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub (facebook#13598) //<Brandon Dail>// - **[8d1038fc6](facebook/react@8d1038fc6)**: Break up ReactDOMServerIntegrationForm-test (facebook#13600) //<Nathan Hunzaker>// - **[b87aabdfe](facebook/react@b87aabdfe)**: Drop the year from Facebook copyright headers and the LICENSE file. (facebook#13593) //<Héctor Ramos>// - **[e417e0bf7](facebook/react@e417e0bf7)**: Update ReactNativeViewConfigRegistry Flow Types (facebook#13579) //<Timothy Yung>// - **[71c0e05ba](facebook/react@71c0e05ba)**: Update bundle sizes for 16.5.0 release //<Brian Vaughn>// - **[6255cc394](facebook/react@6255cc394)**: Updating package versions for release 16.5.0 //<Brian Vaughn>// - **[28cb37978](facebook/react@28cb37978)**: Added a test for Profiler onRender that throws (facebook#13575) //<Brian Vaughn>// - **[8963118b3](facebook/react@8963118b3)**: Update react-dom README //<Dan Abramov>// - **[b47a28cb9](facebook/react@b47a28cb9)**: Tweak react-dom README //<Dan Abramov>// - **[f765f0225](facebook/react@f765f0225)**: When a root expires, flush all expired work in a single batch (facebook#13503) //<Andrew Clark>// - **[550dd1d2e](facebook/react@550dd1d2e)**: Call Profiler onRender after mutations (facebook#13572) //<Brian Vaughn>// - **[34348a45b](facebook/react@34348a45b)**: Add enableSuspenseServerRenderer feature flag (facebook#13573) //<Alex Taylor>// - **[4e744be6e](facebook/react@4e744be6e)**: Added react-dom/profiling entry point to NPM package (facebook#13570) //<Brian Vaughn>// - **[bb627228e](facebook/react@bb627228e)**: test: add test for fragement props (facebook#13565) //<laoxiong>// - **[9a110ebd8](facebook/react@9a110ebd8)**: Cleaned up 'schedule' API wrt interactions and subscriber ref: (facebook#13561) //<Brian Vaughn>// - **[fb88fd9d8](facebook/react@fb88fd9d8)**: Fixed schedule/tracking require for www sync script (facebook#13556) //<Brian Vaughn>// - **[955393cab](facebook/react@955393cab)**: refactor: remove emove type judgment when defining warning props (facebook#13553) //<laoxiong>// - **[ff9399602](facebook/react@ff9399602)**: Fix import of ReactDOM in server env //<Dan Abramov>// - **[281bd64c0](facebook/react@281bd64c0)**: Fix test file name //<Dan Abramov>// - **[d6b59e3d2](facebook/react@d6b59e3d2)**: Check document.documentMode once //<Dan Abramov>// - **[52633c84e](facebook/react@52633c84e)**: Try/finally //<Dan Abramov>// - **[2d4705e75](facebook/react@2d4705e75)**: Make IE 11 not complain about non-crucial style attribute hydration mismatch (facebook#13534) //<Michał Gołębiowski-Owczarek>// - **[25d48a728](facebook/react@25d48a728)**: Add gridArea to unitless CSS properties (facebook#13550) //<Michał Gołębiowski-Owczarek>// - **[877f8bc6b](facebook/react@877f8bc6b)**: Renamed schedule UMD forwarding methods to stay in-sync with SECRET_INTERNALS change (facebook#13549) //<Brian Vaughn>// - **[0a96f9057](facebook/react@0a96f9057)**: Revert "Extract common logic" (facebook#13547) //<Dan Abramov>// - **[17a57adde](facebook/react@17a57adde)**: Fix test //<Dan Abramov>// - **[605da8b42](facebook/react@605da8b42)**: Extract common logic (facebook#13535) //<Heaven>// - **[69f9f4127](facebook/react@69f9f4127)**: Document event bubble order (facebook#13546) //<Philipp>// - **[c1ba7b8cf](facebook/react@c1ba7b8cf)**: Remove www scheduler fork (facebook#13545) //<Dan Abramov>// - **[b473d5f86](facebook/react@b473d5f86)**: Secret exports: Scheduler => Schedule (facebook#13544) //<Dan Abramov>// - **[6312efc34](facebook/react@6312efc34)**: Tweak README and description //<Dan Abramov>// - **[b92f947af](facebook/react@b92f947af)**: Rename "react-scheduler" package to "schedule" (facebook#13543) //<Brian Vaughn>// - **[3c1dcd349](facebook/react@3c1dcd349)**: Expose less internals for TestUtils (facebook#13539) //<Dan Abramov>// - **[0b74e95d7](facebook/react@0b74e95d7)**: Ignore noscript content on the client (facebook#13537) //<Fredrik Höglund>// - **[8a1e3962a](facebook/react@8a1e3962a)**: Remove negative lookbehind from Rollup plugin that broke Node <= v8.9 (facebook#13538) //<Brian Vaughn>// - **[9604d26ae](facebook/react@9604d26ae)**: Rename ReactDOMFiber* to ReactDOM* (facebook#13540) //<Dan Abramov>// - **[28b928902](facebook/react@28b928902)**: Tidied up scheduling UMD API forwarding test (facebook#13533) //<Brian Vaughn>// - **[bf8aa6092](facebook/react@bf8aa6092)**: Added Jest test to verify UMD API-forwarding for scheduling package (facebook#13532) //<Brian Vaughn>// - **[0040efc8d](facebook/react@0040efc8d)**: Fix a typo (facebook#13531) //<Heaven>// - **[46950a3df](facebook/react@46950a3df)**: Interaction tracking follow up (facebook#13509) //<Brian Vaughn>// - **[0452c9bba](facebook/react@0452c9bba)**: Add a regression test for facebook#4618 //<Dan Abramov>// - **[c21bab694](facebook/react@c21bab694)**: Add SSR regression test for facebook#6119 //<Dan Abramov>// - **[0d3fc9de1](facebook/react@0d3fc9de1)**: Add regression test for facebook#6119 //<Dan Abramov>// - **[0f050ad7c](facebook/react@0f050ad7c)**: Make regression test better //<Dan Abramov>// - **[f94342323](facebook/react@f94342323)**: Add a more precise regression test for facebook#6219 //<Dan Abramov>// - **[a3e4d0008](facebook/react@a3e4d0008)**: Fixed typo (facebook#13519) //<Ivan>// - **[b3d8c5376](facebook/react@b3d8c5376)**: [RN] Remove isMounted() false positive warning (facebook#13511) //<Dan Abramov>// - **[d2123d656](facebook/react@d2123d656)**: Sync React Native Flow Changes (facebook#13513) //<Timothy Yung>// - **[1c0ba70b4](facebook/react@1c0ba70b4)**: Fix test to use AsyncMode //<Dan>// - **[6e4f7c788](facebook/react@6e4f7c788)**: Profiler integration with interaction-tracking package (facebook#13253) //<Brian Vaughn>// - **[2967ebdbe](facebook/react@2967ebdbe)**: Remove buggy unstable_deferredUpdates() (facebook#13488) //<Dan Abramov>// - **[1664b08f0](facebook/react@1664b08f0)**: added flow types to setInnerHTML (facebook#13495) //<Bryan M>// - **[672e859d3](facebook/react@672e859d3)**: Add warning to prevent setting this.state to this.props referentially (facebook#11658) //<Veekas Shrivastava>// - **[29287f088](facebook/react@29287f088)**: Rename lowestPendingInteractiveExpirationTime (facebook#13484) //<Heaven>// - **[d400d6d5e](facebook/react@d400d6d5e)**: Replace magic number 1 with ELEMENT_NODE (facebook#13479) //<Heaven>// - **[340bfd939](facebook/react@340bfd939)**: Rename ReactTypeOfWork to ReactWorkTags, ReactTypeOfSideEffect to ReactSideEffectTags (facebook#13476) //<Sophie Alpert>// - **[5cefd9b1e](facebook/react@5cefd9b1e)**: Stringify <option> children (facebook#13465) //<Dan Abramov>// - **[3661616c2](facebook/react@3661616c2)**: Improve test harness of submit events (facebook#13463) //<Philipp Spieß>// - **[a1be17140](facebook/react@a1be17140)**: Revert "Rely on bubbling for submit and reset events (facebook#13358)" (facebook#13462) //<Dan Abramov>// - **[90c92c700](facebook/react@90c92c700)**: Fix warning message //<Dan Abramov>// - **[5cb0f2bf5](facebook/react@5cb0f2bf5)**: Change www error shim API (facebook#13454) //<Dan Abramov>// - **[e106b8c44](facebook/react@e106b8c44)**: Warn about unsafe toWarnDev() nesting in tests (facebook#12457) //<Brian Vaughn>// - **[026aa9c97](facebook/react@026aa9c97)**: Bumped version to 16.4.3-alpha.0 (facebook#13448) //<Brian Vaughn>// - **[d670bdc6b](facebook/react@d670bdc6b)**: Warn about ReactDOM.createPortal usage within ReactTestRenderer (facebook#12895) //<Brian Vaughn>// - **[bf1abf478](facebook/react@bf1abf478)**: Fix React.lazy(forwardRef) (facebook#13446) //<Dan Abramov>// - **[e8571c798](facebook/react@e8571c798)**: Tweak ReactTypeOfWork order (facebook#13444) //<Dan Abramov>// - **[973496b40](facebook/react@973496b40)**: Fix component name for React.lazy (facebook#13443) //<Dan Abramov>// - **[0beb2ee76](facebook/react@0beb2ee76)**: Fix incorrect legacy context for factory components (facebook#13441) //<Dan Abramov>// - **[004cb21bb](facebook/react@004cb21bb)**: Short circuit the logic for exporting a module (facebook#13392) //<Joseph>// - **[f7a538c91](facebook/react@f7a538c91)**: Remove getTextContentAccessor (facebook#13434) //<Brandon Dail>// - **[d1c42d2f1](facebook/react@d1c42d2f1)**: Remove addEventListener check in isEventSupported (facebook#13435) //<Brandon Dail>// - **[a869f992a](facebook/react@a869f992a)**: Remove helper object from FallbackCompositionState (facebook#13430) //<Brandon Dail>// - **[0cd8d470d](facebook/react@0cd8d470d)**: Do not toLowerCase lists of lowercase words (facebook#13428) //<Nathan Hunzaker>// - **[b3a4cfea5](facebook/react@b3a4cfea5)**: Trap click events for portal root (facebook#11927) //<Brandon Dail>// - **[0da5102cf](facebook/react@0da5102cf)**: Add interaction-tracking/subscriptions (facebook#13426) //<Brian Vaughn>// - **[4b32f525e](facebook/react@4b32f525e)**: Refactor away some namespace imports (facebook#13427) //<Dan Abramov>// - **[d2f5c3fbc](facebook/react@d2f5c3fbc)**: Don't diff memoized host components in completion phase (facebook#13423) //<Dan Abramov>// - **[5e0f073d5](facebook/react@5e0f073d5)**: interaction-tracking package (facebook#13234) //<Brian Vaughn>// - **[d14e443d6](facebook/react@d14e443d6)**: Resume onSelect tracking after dragend (facebook#13422) //<Dan Abramov>// - **[d5edc1f51](facebook/react@d5edc1f51)**: Remove unused ReactCall & ReactReturn types (facebook#13419) //<Esteban>// - **[4fa20b53b](facebook/react@4fa20b53b)**: Don't pass instanceHandle to clones (facebook#13125) //<Sebastian Markbåge>// - **[fe959eea7](facebook/react@fe959eea7)**: React.lazy (facebook#13398) //<Andrew Clark>// - **[2b3082800](facebook/react@2b3082800)**: Fix wrong Flow return type //<Andrew Clark>// - **[5031ebf6b](facebook/react@5031ebf6b)**: Accept promise as element type (facebook#13397) //<Andrew Clark>// - **[77b7a660b](facebook/react@77b7a660b)**: fix: do not reconcile children that are iterable functions (facebook#13416) //<Rauno Freiberg>// - **[cb7745c6c](facebook/react@cb7745c6c)**: remove unused state initialValue from ReactDOMFiberSelect (facebook#13412) //<Kartik Lad>// - **[9832a1b6d](facebook/react@9832a1b6d)**: Avoid setting empty value on reset & submit inputs (facebook#12780) //<Ellis Clayton>// - **[8862172fa](facebook/react@8862172fa)**: Provide a better error message (facebook#12421) //<Aaron Brager>// - **[581682917](facebook/react@581682917)**: De-duplicate commitUpdateQueue effect commit (facebook#13403) //<Ruud Burger>// - **[1bc975d07](facebook/react@1bc975d07)**: Don't stop context traversal at matching consumers (facebook#13391) //<Andrew Clark>// - **[83e446e1d](facebook/react@83e446e1d)**: Refactor ReactErrorUtils (facebook#13406) //<Dan Abramov>// - **[13fa96a54](facebook/react@13fa96a54)**: Improve bad ref invariant (facebook#13408) //<Dan Abramov>// - **[b2adcfba3](facebook/react@b2adcfba3)**: Don't suppress jsdom error reporting in our tests (facebook#13401) //<Dan Abramov>// - **[69e2a0d73](facebook/react@69e2a0d73)**: Ability to access window.event in development (facebook#11687) (facebook#11696) //<Conrad Irwin>// - **[ade4dd3f6](facebook/react@ade4dd3f6)**: Fix typo in a comment (facebook#13373) //<davidblnc>// - **[2c59076d2](facebook/react@2c59076d2)**: Warn when "false" or "true" is the value of a boolean DOM prop (facebook#13372) //<Moti Zilberman>// - **[de5102c4c](facebook/react@de5102c4c)**: Ignore symbols and functions in select tag (facebook#13389) //<Rauno Freiberg>// - **[d04d03e47](facebook/react@d04d03e47)**: Fix passing symbols and functions to textarea (facebook#13362) //<Rauno Freiberg>// - **[5550ed4a8](facebook/react@5550ed4a8)**: Ensure arguments are coerced to strings in warnings (facebook#13385) //<Nathan Hunzaker>// - **[3938ccc88](facebook/react@3938ccc88)**: Allow the user to opt out of seeing "The above error..." addendum (facebook#13384) //<Dan Abramov>// - **[47e217a77](facebook/react@47e217a77)**: Provide component reference in ReactDOMFiberTextarea warnings (facebook#13361) //<Rauno Freiberg>// - **[a0190f828](facebook/react@a0190f828)**: Rename SafeValue to ToStringValue (facebook#13376) //<Philipp Spieß>// - **[33602d435](facebook/react@33602d435)**: Improve soundness of ReactDOMFiberInput typings (facebook#13367) //<Philipp Spieß>// - **[ae855cec2](facebook/react@ae855cec2)**: Support tangentialPressure and twist fields of pointer events (facebook#13374) //<Moti Zilberman>// - **[725e499cf](facebook/react@725e499cf)**: Rely on bubbling for submit and reset events (facebook#13358) //<Philipp Spieß>// - **[e07a3cd28](facebook/react@e07a3cd28)**: fix typo on inline comment (facebook#13364) //<Alex Rohleder>// - **[e0204084a](facebook/react@e0204084a)**: Fix typos detected by github.com/client9/misspell (facebook#13349) //<Kazuhiro Sera>// - **[be4533af7](facebook/react@be4533af7)**: Fix hydration of non-string dangerousSetInnerHTML.__html (facebook#13353) //<Dan Abramov>// - **[0072b5998](facebook/react@0072b5998)**: Improve scry() error message for bad first argument (facebook#13351) //<Dan Abramov>// - **[d59b993a7](facebook/react@d59b993a7)**: Make nicer stacks DEV-only //<Dan>// - **[54d86eb82](facebook/react@54d86eb82)**: Improve display of filenames in component stack (facebook#12059) //<Billy Janitsch>// - **[067cc24f5](facebook/react@067cc24f5)**: Profiler actualDuration bugfix (facebook#13313) //<Brian Vaughn>// - **[3cfab14b9](facebook/react@3cfab14b9)**: Treat focusable as enumerated boolean SVG attribute (facebook#13339) //<Dan Abramov>// - **[3b3b7fcbb](facebook/react@3b3b7fcbb)**: Don't search beyond Sync roots for highest priority work (facebook#13335) //<Dan Abramov>// - **[08e32263f](facebook/react@08e32263f)**: Fix Prettier "No parser" warning while building (facebook#13323) //<Bartosz Kaszubowski>// - **[ac7238856](facebook/react@ac7238856)**: Add support for auxclick event (facebook#11571) //<Jason Quense>// - **[75491a8f4](facebook/react@75491a8f4)**: Add a regression test for facebook#12200 (facebook#12242) //<Gareth Small>// - **[2d0356a52](facebook/react@2d0356a52)**: Make sure that `select` has `multiple` attribute set to appropriate state before appending options (facebook#13270) //<Dmytro Zasyadko>// - **[b179bae0a](facebook/react@b179bae0a)**: Enhance get derived state from props state warning - facebook#12670 (facebook#13317) //<Felix Wu>// - **[15a8f0318](facebook/react@15a8f0318)**: Fix ambiguity in doc comment for isValidElement (facebook#12826) //<Alexey>// - **[5cff21207](facebook/react@5cff21207)**: add flowtype to function signature (facebook#13285) //<ryota-murakami>// - **[b565f4953](facebook/react@b565f4953)**: Minimally support iframes (nested browsing contexts) in selection event handling (facebook#12037) //<Andrew Patton>// - **[1609cf343](facebook/react@1609cf343)**: Warn about rendering Generators (facebook#13312) //<Dan Abramov>// - **[46d5afc54](facebook/react@46d5afc54)**: Replace console.error() with a throw in setTimeout() as last resort exception logging (facebook#13310) //<Dan Abramov>// - **[b3b80a483](facebook/react@b3b80a483)**: Inject react-art renderer into react-devtools (facebook#13173) //<Yunchan Cho>// - **[5e8beec84](facebook/react@5e8beec84)**: Add a regression test for facebook#11602 //<Dan Abramov>// - **[470377bbd](facebook/react@470377bbd)**: Remove extraneous condition //<Dan Abramov>// - **[6db080154](facebook/react@6db080154)**: Remove irrelevant suggestion of a legacy method from a warning (facebook#13169) //<Ideveloper>// - **[f60a7f722](facebook/react@f60a7f722)**: Fix SSR crash on a hasOwnProperty attribute (facebook#13303) //<Dan Abramov>// - **[ff41519ec](facebook/react@ff41519ec)**: Sanitize unknown attribute names for SSR (facebook#13302) //<Dan Abramov>// - **[c44c2a216](facebook/react@c44c2a216)**: More helpful message when passing an element to createElement() (facebook#13131) //<Dylan Cutler>// - **[28cd494bd](facebook/react@28cd494bd)**: Refactor validateDOMNesting a bit (facebook#13300) //<Dan Abramov>// - **[b381f4141](facebook/react@b381f4141)**: Allow Electrons <webview> tag (facebook#13301) //<Philipp Spieß>// - **[0182a7463](facebook/react@0182a7463)**: Fix a crash when using dynamic children in <option> tag (facebook#13261) //<Konstantin Yakushin>// - **[2a2ef7e0f](facebook/react@2a2ef7e0f)**: Remove unnecessary branching from updateContextProvider (facebook#13282) //<Andrew Clark>// - **[840cb1a26](facebook/react@840cb1a26)**: Add an invariant to createRoot() to validate containers (facebook#13279) //<Dan Abramov>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions bc1ea9c...ade5e69 Reviewed By: bvaughn Differential Revision: D9561644 fbshipit-source-id: 3be120d7450f310af458897d54993a6c086cff2f

javamonn mentioned this issue May 3, 2017

Tab page change stops working when re-navigating to previously mounted page satya164/react-native-tab-view#225

Closed

This was referenced May 10, 2017

Nested tabs swiping react-navigation/react-navigation#1442

Closed

[Android] scroll stopped working satya164/react-native-tab-view#246

Closed

flyskywhy mentioned this issue May 22, 2017

[iOS][RefreshControl] broken after re-enter app #13977

Closed

bood mentioned this issue Jun 5, 2017

ViewPagerAndroid renders empty dynamically added views after upgrade from v0.42.3 to v0.44.2 #14296

Closed

satya164 mentioned this issue Aug 4, 2017

Fix ViewPager being stuck in some scenarios #15376

Closed

This was referenced Aug 11, 2017

Remove non-working android specific code for scrollview leecade/react-native-swiper#479

Closed

Fix android issue with dynamically added children leecade/react-native-swiper#514

Merged

satya164 mentioned this issue Aug 14, 2017

initialLayout behaves differently with and without js remote dedbug satya164/react-native-tab-view#330

Closed

stale bot added the Stale label Nov 16, 2017

stale bot removed the Stale label Nov 17, 2017

liuzhibopp closed this as completed Nov 17, 2017

satya164 reopened this Nov 24, 2017

bood mentioned this issue Jan 4, 2018

Fix Viewpager on Android when using native navigation. #14867

Closed

satya164 mentioned this issue Mar 5, 2018

[Help] [Android only] Tab Switching freezes after a new screen is pushed from the tabbed view satya164/react-native-tab-view#474

Closed

react-native-bot added Android Resolution: PR Submitted labels Mar 9, 2018

madhu314 mentioned this issue Mar 15, 2018

Bug when another component opened and then backed to this one madhu314/react-native-tabbed-view-pager-android#7

Closed

janicduplessis removed the Android 🤖 label Mar 19, 2018

hramos closed this as completed May 17, 2018

hramos added the Resolution: Fixed label May 17, 2018

crisward mentioned this issue Jul 24, 2018

Android blank view zbtang/React-Native-ViewPager#142

Open

martabacc mentioned this issue Dec 5, 2018

Remove ViewPagerAndroid, use ScrollView for all Platform leecade/react-native-swiper#902

Open

facebook locked as resolved and limited conversation to collaborators Dec 11, 2019

react-native-bot added the Resolution: Locked label Dec 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React Native v0.43 ViewPagerAndroid work not well when detached then attach #13463

React Native v0.43 ViewPagerAndroid work not well when detached then attach #13463

liuzhibopp commented Apr 12, 2017

henrytao-me commented Apr 23, 2017

liuzhibopp commented Apr 24, 2017

satya164 commented May 10, 2017

sibelius commented May 11, 2017

bood commented May 22, 2017 •

edited

Loading

astreet commented May 22, 2017

Jackoder commented Jun 5, 2017 •

edited

Loading

itinance commented Jun 25, 2017

cbjs commented Jul 19, 2017

INCHMAN1900 commented Sep 17, 2017 •

edited

Loading

stale bot commented Nov 16, 2017

liuzhibopp commented Nov 17, 2017

Noitidart commented Nov 30, 2017 •

edited

Loading

Noitidart commented Dec 1, 2017 •

edited

Loading

danilobuerger commented Dec 24, 2017

satya164 commented Dec 24, 2017

danilobuerger commented Dec 24, 2017

satya164 commented Dec 24, 2017 •

edited

Loading

danilobuerger commented Dec 28, 2017

danilobuerger commented Dec 28, 2017

satya164 commented Dec 28, 2017

danilobuerger commented Dec 28, 2017

satya164 commented Dec 28, 2017

bood commented Jan 4, 2018

satya164 commented Jan 4, 2018

bood commented Jan 4, 2018

hramos commented May 17, 2018

React Native v0.43 ViewPagerAndroid work not well when detached then attach #13463

React Native v0.43 ViewPagerAndroid work not well when detached then attach #13463

Comments

liuzhibopp commented Apr 12, 2017

Description

Reproduction Steps and Sample Code

Solution

henrytao-me commented Apr 23, 2017

ViewPagerAndroidContainer

Usage

liuzhibopp commented Apr 24, 2017

satya164 commented May 10, 2017

sibelius commented May 11, 2017

bood commented May 22, 2017 • edited Loading

astreet commented May 22, 2017

Jackoder commented Jun 5, 2017 • edited Loading

itinance commented Jun 25, 2017

cbjs commented Jul 19, 2017

INCHMAN1900 commented Sep 17, 2017 • edited Loading

stale bot commented Nov 16, 2017

liuzhibopp commented Nov 17, 2017

Noitidart commented Nov 30, 2017 • edited Loading

Noitidart commented Dec 1, 2017 • edited Loading

danilobuerger commented Dec 24, 2017

satya164 commented Dec 24, 2017

danilobuerger commented Dec 24, 2017

satya164 commented Dec 24, 2017 • edited Loading

danilobuerger commented Dec 28, 2017

danilobuerger commented Dec 28, 2017

satya164 commented Dec 28, 2017

danilobuerger commented Dec 28, 2017

satya164 commented Dec 28, 2017

bood commented Jan 4, 2018

satya164 commented Jan 4, 2018

bood commented Jan 4, 2018

hramos commented May 17, 2018

bood commented May 22, 2017 •

edited

Loading

Jackoder commented Jun 5, 2017 •

edited

Loading

INCHMAN1900 commented Sep 17, 2017 •

edited

Loading

Noitidart commented Nov 30, 2017 •

edited

Loading

Noitidart commented Dec 1, 2017 •

edited

Loading

satya164 commented Dec 24, 2017 •

edited

Loading