Fix a crash issue when meeting up NSMapTable with NSPointerFunctionsOpaqueMemory. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushuangqing
changed the title
xushuangqing
changed the title
|
Awesome change, thanks for this :) |
|
@Megra It's a good change, Please type a new release package？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash issue when meeting up NSMapTable with NSPointerFunctionsOpaqueMemory.
#60 (comment)
For
NSMapTablewithNSPointerFunctionsOpaqueMemory, FBRetainCycleDetector treats inner object as strong reference, aspointerFunctions.usesWeakReadAndWriteBarriersreturns NO.acquireFunctionis called for copy-in operations. IfacquireFunctionis NULL, it means nothing will be done when copied-in, so the memory will not be retained.It cannot be guarantee that
acquireFunctionis always NULL when the memory option is NSPointerFunctionsOpaqueMemory. But it is better than we do nothing.The crash can be reproduced in the added test case.