Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: also check overflowY: overlay in detectScroll #4806

Merged
merged 2 commits into from Feb 18, 2022
Merged

fix: also check overflowY: overlay in detectScroll #4806

merged 2 commits into from Feb 18, 2022

Conversation

andelf
Copy link
Contributor

@andelf andelf commented Feb 18, 2022

Ref: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow

Behaves the same as auto, but with the scrollbars drawn on top of content instead of taking up space. Only supported in WebKit-based (e.g., Safari) and Blink-based (e.g., Chrome or Opera) browsers.

@vercel
Copy link

vercel bot commented Feb 18, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

excalidraw-package-example – ./src/packages/excalidraw

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-package-example/B8LpeDK8JxzWSp7XS9UiHNUPKGoc
✅ Preview: https://excalidraw-package-example-git-fork-andelf-patch-1-excalidraw.vercel.app

excalidraw – ./

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/FkUtip3CQxBeVyT7xVYNZLuCj6Hm
✅ Preview: https://excalidraw-git-fork-andelf-patch-1-excalidraw.vercel.app

@andelf andelf mentioned this pull request Feb 18, 2022
Closed
@dwelle
Copy link
Member

dwelle commented Feb 18, 2022

I would have sworn it was listed already, but apparently not. Thanks for the fix!

@dwelle dwelle merged commit f792eb5 into excalidraw:master Feb 18, 2022
@andelf andelf deleted the patch-1 branch February 18, 2022 23:20
@tokuhirom
Copy link

@dwelle could you release new version, that includes this patch？

@dwelle
Copy link
Member

dwelle commented Mar 26, 2022

@tokuhirom sorry for replying late. It'll take some time before we release a new stable version, but you can use https://www.npmjs.com/package/@excalidraw/excalidraw-next if you need this asap

@andelf andelf mentioned this pull request Apr 19, 2022
Closed
@pengx17 pengx17 mentioned this pull request Apr 30, 2022
Closed
5 tasks
@sprocketc sprocketc mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelle dwelle dwelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andelf @dwelle @tokuhirom