Deprecate EIP-777 #7340
Merged
Deprecate EIP-777 #7340
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
github-actions
bot
added
content 🖋️
|
EIP-777 is tricky to implement correctly (it's particularly vulnerable to reentrancy attacks because it can't follow the checks effects interactions pattern) and is not widely used. OpenZeppelin is planning on hiding their EIP-777 implementation from the documentation in an effort to deprecate it. |
|
Thanks @Pandapip1. Curious if you think we should still have a page on EIP-777? |
|
I think we should, even as a historical archive. |
|
Bump. |
axic
reviewed
Aug 24, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
minimalsm
previously approved these changes
Sep 9, 2022
minimalsm
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a deprecation notice next to the mention of EIP-777 on the standards page.
Related Issue
N.A.