Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmg icon get a wrong position if productName contains Unicode character #1369

Closed
changkun opened this issue Mar 14, 2017 · 4 comments
Closed

dmg icon get a wrong position if productName contains Unicode character #1369

changkun opened this issue Mar 14, 2017 · 4 comments
Labels
duplicate

Comments

@changkun
Copy link
Contributor

changkun commented Mar 14, 2017 •
edited
Loading

  • Version: 15.4.2
  • Target: macOS

package.json build field:

  "build": {
    "appId": "test.test",
    "productName": "Test",
    "directories": {"buildResources": "assets"},
    "mac": {
      "category": "public.app-category.entertainment",
      "target": [ "dmg" ],
      "icon": "assets/icon.icns"
    },
    "dmg": {
      "contents": [
        {
          "x": 415,
          "y": 170,
          "type": "link",
          "path": "/Applications"
        },
        {
          "x": 135,
          "y": 170,
          "type": "file"
        }
      ]
    },
    "win": {"target": ["nsis"]},
    "linux": {"target": ["deb"]}
  },

Wrong position if productName contains unicode characters
screen shot 2017-03-14 at 17 21 29
Correct position if productName only english character
screen shot 2017-03-14 at 17 11 21
@changkun changkun changed the title dmg icon get a wrong position if productName is Chinese character dmg icon get a wrong position if productName contains Unicode character Mar 14, 2017
@changkun
Copy link
Contributor Author

This is a bug since 89f7f6a.

@develar
Copy link
Member

develar commented Mar 15, 2017

Probably we should force utf8 encoding for perl source file. Sorry for delay, I will investigate in 2 days.

@changkun
Copy link
Contributor Author

changkun commented Mar 15, 2017 •
edited
Loading

@develar Somehow you removed UTF8 encoding from line 48, and you execute the perl script that contains utf-8 character, I would guess this is the source of the bug.

@changkun changkun mentioned this issue Mar 15, 2017
Merged
@develar
Copy link
Member

develar commented Mar 15, 2017

Duplicates #1234

@develar develar closed this as completed Mar 15, 2017
@daumling daumling mentioned this issue Aug 21, 2017
Closed
@jebibot jebibot mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develar @changkun