Skip to content

Electron 5 doesn't have require available on window #17208

New issue
New issue
Closed
Closed
Electron 5 doesn't have require available on window#17208
@natew

Description

@natew
natew
opened on Mar 4, 2019
Contributor
  • Electron Version: 5.0.0-beta.4
  • Operating System: macOS 10.13.6
  • Last Known Working Electron version:: 4.0.6

Expected Behavior

window.require exists.

Actual Behavior

typeof window.require === 'undefined'

To Reproduce

git clone https://github.com/electron/simple-samples
cd activity-monitor
npm i electron@5.0.0-beta.4
npm start

Screenshots

image

Activity

MarshallOfSound

MarshallOfSound commented on Mar 4, 2019

@MarshallOfSound
MarshallOfSound
on Mar 4, 2019
Member

This is an intended change in behavior and is listed in our breaking changes document. The default value for nodeIntegration changed.

https://github.com/electron/electron/blob/v5.0.0-beta.1/docs/api/breaking-changes.md#planned-breaking-api-changes-50

MarshallOfSound
closed this as completedon Mar 4, 2019
natew
mentioned this on Mar 4, 2019
natew

natew commented on Mar 4, 2019

@natew
natew
on Mar 4, 2019
ContributorAuthor

Ah, looked all over blog and releases for that and didn't see the breaking changes document. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @natew@MarshallOfSound

        Issue actions
          Electron 5 doesn't have require available on window · Issue #17208 · electron/electron