Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_missing takes no effect in Rename Ingest Processor #74248

Merged
merged 2 commits into from Jun 25, 2021

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jun 17, 2021

Relates to #74241.

The changes are:

  1. Fix the bug, when rendered field of the template snippets does not exist and ignore_missing is true, rename processor should exit quietly.
  2. Add some tests for the code change.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 17, 2021
@matriv matriv added the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Jun 18, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann
Copy link
Contributor

@elasticmachine ok to test

@danhermann danhermann self-requested a review June 24, 2021 22:05
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong, thank you for fixing this. I'll get it merged and backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants