Enhance and add more tests for ResizeRequest #68502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dakrone ,can you take a look at this PR? |
dakrone
added
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (Team:Core/Features) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joegallo
reviewed
Feb 8, 2021
server/src/test/java/org/elasticsearch/action/admin/indices/shrink/ResizeRequestTests.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
by converting it to unchecked exceptions, and then use it to create random create index requests.
to cover testEqualsAndHashcode and testSerialization
This is handled for us by AbstractWireTestCase#testEqualsAndHashcode
|
@gaobinlong thanks again for your patience, and apologies that it took me so long to get back to this. I've added some new commits -- do you think this is still a fair attempt at what you were trying to accomplish? |
|
Yeah, it looks great! That's really what I wanted! |
|
@dakrone I don't think it's fair for me to be a reviewer here anymore -- do you mind taking a look at things? |
dakrone
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #65714 and follows #67705.
The main changes of this PR are:
equalsandhashCodemethods inResizeRequest.Add the newly added(edit: pulled out into Add max_single_primary_size to ResizeRequest's toXContent #68793)max_single_primary_sizeparameter to theXContentofResizeRequest.testEqualsAndHashCodeandtestSerializeRequestforResizeRequest.