add ignore_empty_value parameter in set ingest processor #57030
Conversation
cbuescher
added
the
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management
|
@elasticmachine ok to test |
|
@elasticmachine update branch |
There was a problem hiding this comment.
@gaobinlong, this looks great. I left two minor changes below and I'll get it merged if those look good to you.
server/src/main/java/org/elasticsearch/ingest/IngestDocument.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Hermann <danhermann@users.noreply.github.com>
Co-authored-by: Dan Hermann <danhermann@users.noreply.github.com>
|
@elasticmachine update branch |
|
@gaobinlong, sorry for the delay on this one. If you can fix the two new compile errors (just add another boolean parameter to the |
|
@danhermann, I have done that and all checks have passed. |
|
Thank you, @gaobinlong! I've merged this and will also get it back-ported to the appropriate branches. |
|
@gaobinlong Just wanted to say thank you for the contribution, I had a issue open on this for a while and it allows me to do some fairly nice changes to pipelines :) |
Relates: elastic/elasticsearch#57030 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Relates: elastic/elasticsearch#57030 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Relates to #54783.
The main point of this PR is adding
ignore_empty_valuein set ingest processr, which can exit quitely if thetemplated valueis null or emtpy string when the parameter is set totrue.Because the
template valuelike{{foo}}produces empty string when the fieldfoodoes not exist, isnullorempty string, so the parameterignore_empty_valueignores bothnullorempty stringwhen it's set totrue.