Throw an illegal_argument_exception when max_docs is less than slices #54901
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
the
:Distributed Indexing/Reindex
|
Pinging @elastic/es-distributed (:Distributed/Reindex) |
|
Anyone can help to review this change? |
rjernst
added
the
Team:Distributed (Obsolete)
|
@elasticmachine test this please |
henningandersen
approved these changes
May 28, 2020
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
May 29, 2020
When the parameter `max_docs` is less than `slices` in update_by_query, delete_by_query or reindex API, `max_docs ` is set to 0 and we throw an action_request_validation_exception with confused error message: "maxDocs should be greater than 0...". This change checks that whether `max_docs` is less than `slices` and throw an illegal_argument_exception with clear message. Relates to elastic#52786.
henningandersen
added a commit
that referenced
this pull request
May 29, 2020
When the parameter `max_docs` is less than `slices` in update_by_query, delete_by_query or reindex API, `max_docs ` is set to 0 and we throw an action_request_validation_exception with confused error message: "maxDocs should be greater than 0...". This change checks that whether `max_docs` is less than `slices` and throw an illegal_argument_exception with clear message. Relates to #52786. Co-authored-by: bellengao <gbl_long@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #52786.
When the parameter
max_docsis less thanslicesin update_by_query, delete_by_query or reindex API,max_docsis set to 0 and we throw an action_request_validation_exception with confused error message: "maxDocs should be greater than 0...".This change checks that whether
max_docsis less thanslicesand throw an illegal_argument_exception with clear message.