Support array for all string ingest processors #53343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matriv
added
the
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
@elasticmachine ok to test |
danhermann
suggested changes
Mar 16, 2020
There was a problem hiding this comment.
@gaobinlong, thanks for making this improvement to all the string ingest processors and for updating the docs and tests as well. I suggested a few changes in wording to the docs and error messages. Once those are in, I will get this merged.
...les/ingest-common/src/main/java/org/elasticsearch/ingest/common/AbstractStringProcessor.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
…ommon/AbstractStringProcessor.java Co-Authored-By: Dan Hermann <danhermann@users.noreply.github.com>
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 18, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor will lowercase values in arrays. This is causing the integration tests to fail.
adriansr
added a commit
to elastic/beats
that referenced
this pull request
Mar 18, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor will lowercase values in arrays. This is causing the integration tests to fail.
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Mar 19, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor will lowercase values in arrays. This is causing the integration tests to fail. (cherry picked from commit 0731f45)
adriansr
added a commit
to elastic/beats
that referenced
this pull request
Mar 19, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor will lowercase values in arrays. This is causing the integration tests to fail. (cherry picked from commit 0731f45)
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #51087.
This work comes from the enhancement that lowercase and uppercase processors can support field with multi values, but lowercase and uppercase processors are
AbstractStringProcessor,so maybe we can support array for all the string ingest processors below: