Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation of the number_of_shards to the beginning of the ILM shrink step #72724

Closed
joegallo opened this issue May 4, 2021 · 3 comments
Closed

Add validation of the number_of_shards to the beginning of the ILM shrink step #72724

joegallo opened this issue May 4, 2021 · 3 comments
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team

Comments

@joegallo
Copy link
Contributor

joegallo commented May 4, 2021

The ILM shrink action can't succeed if the requested number_of_shards won't work with the index's number_of_shards. An example of that would be if the index currently has 3 shards, the policy tries to shrink it down to 2 shards.

Rather than running the set-single-node-allocation allocation step successfully and then failing at the shrink step, we should have validation that checks for this scenario and fails the shrink action without having moved the shards around.
@joegallo joegallo added >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management needs:triage Requires assignment of a team area label labels May 4, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@joegallo
Copy link
Contributor Author

joegallo commented May 4, 2021

Related to #56062 because this could be one of the potential failure cases mentioned there.

@gwbrown gwbrown removed the needs:triage Requires assignment of a team area label label May 12, 2021
@gaobinlong gaobinlong mentioned this issue Jun 17, 2021
Merged
@andreidan
Copy link
Contributor

Fixed by #76565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joegallo @andreidan @gwbrown @elasticmachine