Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return snapshots in progress when ignore_unavailable is set to true in Get Snapshots API #68090

Closed
gaobinlong opened this issue Jan 28, 2021 · 1 comment · Fixed by #68091
Closed

Return snapshots in progress when ignore_unavailable is set to true in Get Snapshots API #68090

gaobinlong opened this issue Jan 28, 2021 · 1 comment · Fixed by #68091
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team

Comments

@gaobinlong
Copy link
Contributor

gaobinlong commented Jan 28, 2021 •
edited

Elasticsearch version (bin/elasticsearch --version): master,7.5.1,6.8.2

Plugins installed: []

JVM version (java -version): 14

OS version (uname -a if on a Unix-like system): macos 10.13.6

Description of the problem including expected versus actual behavior:

When executing Get Snapshots API, if the target snapshot does not exist, and ignore_unavailable is set to true, then the API returns all the snapshots which are in progress.

Steps to reproduce:

  1. Create a snapshot which will take a long time to execute.
PUT _snapshot/my_repository/snap1
{
 "indices":["y"]
}
  1. Get an unknown snapshot, and set ignore_unavailable to true
GET _snapshot/my_repository/xxx?ignore_unavailable=true

then you can see the snap1 existed in the response.
@gaobinlong gaobinlong added >bug needs:triage Requires assignment of a team area label labels Jan 28, 2021
@gaobinlong gaobinlong mentioned this issue Jan 28, 2021
Merged
@original-brownbear original-brownbear added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed needs:triage Requires assignment of a team area label labels Jan 28, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Jan 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear pushed a commit that referenced this issue Jan 29, 2021
@gaobinlong
Fix Missing Filtering in Get Snapshots API for ignore_missing=true (#…
7793a95 
…68091)

Currently running snapshots were not filtered by name correctly if `ignore_missing`  was set to `true`

Closes #68090
alyokaz pushed a commit to alyokaz/elasticsearch that referenced this issue Mar 10, 2021
@gaobinlong
Fix Missing Filtering in Get Snapshots API for ignore_missing=true (e…
5d23aca 
…lastic#68091)

Currently running snapshots were not filtered by name correctly if `ignore_missing`  was set to `true`

Closes elastic#68090
easyice pushed a commit to easyice/elasticsearch that referenced this issue Mar 25, 2021
@gaobinlong @easyice
Fix Missing Filtering in Get Snapshots API for ignore_missing=true (e…
95f6170 
…lastic#68091)

Currently running snapshots were not filtered by name correctly if `ignore_missing`  was set to `true`

Closes elastic#68090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong response for Get Snapshots API gaobinlong/elasticsearch
3 participants
@original-brownbear @gaobinlong @elasticmachine