feat: support contextFormatter #51
Merged
+79
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
commented
Mar 13, 2019
| @@ -80,7 +80,8 @@ module.exports = { | |||
| meta = meta || {}; | |||
| let message; | |||
| let output; | |||
| const formatter = meta.formatter || options.formatter; | |||
| let formatter = meta.formatter || options.formatter; | |||
| if (meta.ctx && options.contextFormatter) formatter = options.contextFormatter; | |||
There was a problem hiding this comment.
contextFormatter 没有默认值，如果定义了则用之
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 99.45% 99.45% +<.01%
==========================================
Files 14 14
Lines 368 369 +1
==========================================
+ Hits 366 367 +1
Misses 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 99.45% 99.45% +<.01%
==========================================
Files 14 14
Lines 368 370 +2
==========================================
+ Hits 366 368 +2
Misses 2 2
Continue to review full report at Codecov.
|
atian25
approved these changes
Mar 13, 2019
index.d.ts
Outdated
| @@ -20,6 +20,7 @@ export interface LoggerOptions { | |||
| export interface EggLoggerOptions extends LoggerOptions { | |||
| file: string; | |||
| formatter?: any; | |||
There was a problem hiding this comment.
Suggested change
| formatter?: any; | |
| formatter?: (meta?: object) => string; |
atian25
approved these changes
Mar 13, 2019
Co-Authored-By: popomore <sakura9515@gmail.com>
atian25
approved these changes
Mar 13, 2019
lib/egg/context_logger.js
Outdated
| @@ -44,6 +44,7 @@ class ContextLogger { | |||
| const meta = { | |||
| formatter: contextFormatter, | |||
| paddingMessage: this.paddingMessage, | |||
| ctx: this.ctx, | |||
There was a problem hiding this comment.
要不要 define 为不可枚举的，避免之前的 logger 有 JSON.stringify 的
This comment has been minimized.
This comment has been minimized.
|
atian25
pushed a commit
that referenced
this pull request
Apr 17, 2019
4 tasks
atian25
pushed a commit
that referenced
this pull request
Apr 17, 2019
atian25
pushed a commit
that referenced
this pull request
May 7, 2019
atian25
pushed a commit
that referenced
this pull request
May 7, 2019
atian25
added a commit
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Ref #46 #37